openWindow test appears to be looking at the wrong arg

NEW
Unassigned

Status

3 years ago
3 years ago

People

(Reporter: scolville, Unassigned)

Tracking

Details

Whilst implementing tests the JS validiator I noticed that this test [1] 

is checking code like so:

var foo = Cc["foo"].getService(Components.interfaces.nsIWindowWatcher);
foo.openWindow("chrome://foo/bar")

So this code being tested is using the first arg for the uri. In the MDN docs the uri looks to be the second arg [2]

[1] https://github.com/mozilla/amo-validator/blob/7a8011aba8bf8c665aef2b51eb26d0697b3e19c3/tests/test_js_xpcom.py#L293

[2] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIWindowWatcher#openWindow()
(Assignee)

Updated

3 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.