using the MSAA inspect tool. when tabbing to the select and then navigating to the button the highlight circle is drawn in the wrong location. When using mouseover the button is not found, due to the wrong reporting of the bounds. The problem occured because the GetRect() metheod adjusts for the location of the button in the ComboboxControlFrame, but we add that to an already adjusted location and were therefor adding in the X offset twice ( the Y direction worked out ok ). Posting a patch that sets the location of the Rect absolutely. Not sure if this is going to mess up other calculations, currently testing.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.9
Created attachment 66501 [details] [diff] [review] hack to fix the problem Fixes the problem of bad bounds reporting for one specific case, checking to see if we need to be aware of other cases, or if this is the only time we enter this code
Created attachment 66534 [details] [diff] [review] more elegant - change the bounding frame This fixes the problem without introducing the strange absolute positioning needed in first patch. :-)
Attachment #66501 - Attachment is obsolete: true
Comment on attachment 66534 [details] [diff] [review] more elegant - change the bounding frame r=aaronl
Attachment #66534 - Flags: review+
Comment on attachment 66534 [details] [diff] [review] more elegant - change the bounding frame For the frame impaired such as myself, could you add a comment before the GetNextSibling call to say what frame that sibling is, why it's the right one? Or would that be commenting the obvious based on code not in the diff, but nearby? firstname.lastname@example.org. /be
Attachment #66534 - Flags: superreview+
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.