bounds on buttons for HTML Selects reported wrong

RESOLVED FIXED in mozilla0.9.9

Status

()

Core
XUL
P2
normal
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: John Gaunt (redfive), Assigned: John Gaunt (redfive))

Tracking

Trunk
mozilla0.9.9
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

17 years ago
using the MSAA inspect tool.

when tabbing to the select and then navigating to the button the highlight
circle is drawn in the wrong location. 

When using mouseover the button is not found, due to the wrong reporting of the
bounds. 

The problem occured because the GetRect() metheod adjusts for the location of
the button in the ComboboxControlFrame, but we add that to an already adjusted
location and were therefor adding in the X offset twice ( the Y direction worked
out ok ).

Posting a patch that sets the location of the Rect absolutely. Not sure if this
is going to mess up other calculations, currently testing.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 1

17 years ago
Created attachment 66501 [details] [diff] [review]
hack to fix the problem

Fixes the problem of bad bounds reporting for one specific case, checking to
see if we need to be aware of other cases, or if this is the only time we enter
this code
(Assignee)

Comment 2

17 years ago
Created attachment 66534 [details] [diff] [review]
more elegant - change the bounding frame

This fixes the problem without introducing the strange absolute positioning
needed in first patch. :-)
Attachment #66501 - Attachment is obsolete: true

Comment 3

17 years ago
Comment on attachment 66534 [details] [diff] [review]
more elegant - change the bounding frame

r=aaronl
Attachment #66534 - Flags: review+
Comment on attachment 66534 [details] [diff] [review]
more elegant - change the bounding frame

For the frame impaired such as myself, could you add a comment before the
GetNextSibling call to say what frame that sibling is, why it's the right one? 
Or would that be commenting the obvious based on code not in the diff, but
nearby?

sr=brendan@mozilla.org.

/be
Attachment #66534 - Flags: superreview+
(Assignee)

Comment 5

17 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.