Add 'Learn More...' link in notifications management dialog

VERIFIED FIXED in Firefox 44, Firefox OS v2.5

Status

()

Toolkit
Notifications and Alerts
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: edwong, Assigned: MattN)

Tracking

44 Branch
mozilla45
Points:
---

Firefox Tracking Flags

(firefox43 unaffected, firefox44 verified, firefox45 verified, b2g-v2.5 fixed)

Details

User Story

As a user, I want a highly discoverable way to learn more about push notifications so that I can make decisions to allow or block them.

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

3 years ago
User Story: (updated)
(Reporter)

Comment 1

3 years ago
someone commented: Maybe we don't need this now that we are showing the Learn More content upon upgrade?

I would say - that will only display for users with existing allow notifications.
(Reporter)

Comment 2

3 years ago
or help icon
Created attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws
Attachment #8680512 - Flags: review?(jaws)
Landed without waiting for review due to string freeze and since it's pretty straightforward. Part of the change to the markup was to fix an existing problem with vertical alignment.
had to back this out because this conflicts with the m-c to fx-team merge and block this because :

(run 'hg heads' to see heads, 'hg merge' to merge)
merging browser/components/preferences/in-content/content.js
merging browser/components/preferences/in-content/content.xul
warning: conflicts during merge.
merging browser/components/preferences/in-content/content.xul incomplete! (edit conflicts, then use 'hg resolve --mark')
merging browser/locales/en-US/chrome/browser/preferences/content.dtd
warning: conflicts during merge.
merging browser/locales/en-US/chrome/browser/preferences/content.dtd incomplete! (edit conflicts, then use 'hg resolve --mark')
236 files updated, 1 files merged, 8 files removed, 2 files unresolved
use 'hg resolve' to retry unresolved file merges or 'hg update -C .' to abandon
Flags: needinfo?(MattN+bmo)
Comment on attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

https://reviewboard.mozilla.org/r/23635/#review21151
Attachment #8680512 - Flags: review?(jaws) → review+
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Comment on attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws
Flags: needinfo?(MattN+bmo)
https://hg.mozilla.org/mozilla-central/rev/dc2d174f1f4a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
status-firefox43: --- → unaffected
Comment on attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

Approval Request Comment
[Feature/regressing bug #]: Notifications in Fx44
[User impact if declined]: No link to learn about what the notification permission is about
[Describe test coverage new/current, TreeHerder]: Nightly testing on m-c
[Risks and why]: Low risk following convention of other learn more links
[String/UUID change made/needed]: Yes, string landing before regular cut-off date
Attachment #8680512 - Flags: approval-mozilla-aurora?
Verified that the "Learn More..." link was added in the notifications management dialog (in about:preferences#content).

Verified as fixed using the latest Firefox Nightly 45(Build ID: 20151103030248) and the latest Aurora 44 (Build ID: 20151103004217) on Ubuntu 14.04 x64, Windows 7x64 and Mac OS X 10.9:

Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Firefox/45.0

Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:44.0) Gecko/20100101 Firefox/44.0
Status: RESOLVED → VERIFIED
status-firefox44: fixed → verified
status-firefox45: fixed → verified
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
Comment on attachment 8680512 [details]
MozReview Request: Bug 1218908 - Add 'Learn more' link with notification preferences. r=jaws

This has already landed on Aurora44 as part of blanket approval.
Attachment #8680512 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.