1218912 - test_geolocation_prompt.py blocks Jenkins jobs for functional.non-smoke.2 tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Max Ivanov[:MaxIvanov]]

Today we were unable to got working HTML report for functional.non-smoke.2 tests because of blocking all Jenkins jobs by test_geolocation_prompt.py test.

http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2.bitbar/375/console

http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.tinderbox.ui.functional.non-smoke.2.bitbar/709/console

06:51:16 87:34.40 TEST_START: MainThread test_geolocation_prompt.py TestGeolocationPrompt.test_geolocation_prompt
08:18:45 Build timed out (after 180 minutes). Marking the build as aborted.
08:18:45 FATAL: Caught exception while loading script 'Run Gaia tests'
08:18:45 java.lang.InterruptedException
08:18:45 	at java.lang.Object.wait(Native Method)
08:18:45 	at java.lang.Object.wait(Object.java:503)
08:18:45 	at java.lang.UNIXProcess.waitFor(UNIXProcess.java:263)
08:18:45 	at hudson.Proc$LocalProc.join(Proc.java:319)
08:18:45 	at hudson.Launcher$ProcStarter.join(Launcher.java:388)
08:18:45 	at org.jenkinsci.plugins.managedscripts.ScriptBuildStep.perform(ScriptBuildStep.java:187)
08:18:45 	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
08:18:45 	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:776)
08:18:45 	at hudson.model.Build$BuildExecution.build(Build.java:203)
08:18:45 	at hudson.model.Build$BuildExecution.doRun(Build.java:160)
08:18:45 	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:536)
08:18:45 	at hudson.model.Run.execute(Run.java:1738)
08:18:45 	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
08:18:45 	at hudson.model.ResourceController.execute(ResourceController.java:98)
08:18:45 	at hudson.model.Executor.run(Executor.java:381)
08:18:45 Build step 'Execute managed script' marked build as failure
08:18:45 [Testdroid] - Releasing device session
08:18:46 Deleting 2 temporary files
08:18:46 Archiving artifacts
08:18:46 [htmlpublisher] Archiving HTML reports...
08:18:46 [htmlpublisher] Archiving at BUILD level /var/lib/jenkins/jobs/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2.bitbar/workspace/tests/python/gaia-ui-tests/report to /var/lib/jenkins/jobs/flame-kk-319.mozilla-central.nightly.ui.functional.non-smoke.2.bitbar/builds/375/htmlreports/HTML_Report
08:18:46 Recording test results
08:18:46 Found 2 test results
08:18:46 Found failed test junit/results/xml
08:18:48 Found failed test junit/results/xml/_init_
08:18:48 Sending e-mails to: [e-mail]
08:18:48 Finished: FAILURE

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1218912 > mozilla-b2g:master

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 8679723 [details] [review]
[gaia] mwargers:1218912 > mozilla-b2g:master

I wonder if _safe_wait is still necessary with the changes they recently did regarding the statusbar.

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8679723 [details] [review]
[gaia] mwargers:1218912 > mozilla-b2g:master

seems good to me.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8679723 [details] [review]
[gaia] mwargers:1218912 > mozilla-b2g:master

test_geolocation_prompt.py works fine. I checked the status bar in WebIDE and the DOM element doesn't get refreshed at each action. I locally removed the part related to safe_wait: it passes. We can get rid of that method, which was actually creating this endless wait :S

I couldn't test the airplane mode part, because the DOM has changed in bug  	1172349. I filed bug 1219619 to make the change. I suggest to remove that part from the PR, and put it in bug 1219619.

In a nutshell: r+ modulo airplane mode.

Comment 5

[Martijn Wargers (dead)]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> Comment on attachment 8679723 [details] [review]
> [gaia] mwargers:1218912 > mozilla-b2g:master
> 
> test_geolocation_prompt.py works fine. I checked the status bar in WebIDE
> and the DOM element doesn't get refreshed at each action. I locally removed
> the part related to safe_wait: it passes. We can get rid of that method,
> which was actually creating this endless wait :S
> 
> I couldn't test the airplane mode part, because the DOM has changed in bug  
> 1172349. I filed bug 1219619 to make the change. I suggest to remove that
> part from the PR, and put it in bug 1219619.

Oh, yes, I see. I've made a pull request in bug 1219332 that should fix things and makes it possible to test the airplone mode part. I just tested this pull request combined with the pull request of bug 1219332 and it makes test_settings_airplane_mode.py and test_geolocation_prompt.py pass.

Comment 6

[Martijn Wargers (dead)]

Chatted with jlorenzo on irc and he agreed this could be merged.
Merged: https://github.com/mozilla-b2g/gaia/commit/20a6205f418ef65b97f7ee39dc1cc13096c3eedb

Comment 7

[Martijn Wargers (dead)]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> test_geolocation_prompt.py works fine. I checked the status bar in WebIDE
> and the DOM element doesn't get refreshed at each action. I locally removed
> the part related to safe_wait: it passes. We can get rid of that method,
> which was actually creating this endless wait :S

Oops! I forgot to do this. I've filed bug 1219827 for it now.