1218913 - Explicitly state types in json schemas, when possible

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

The golang taskcluster client relies on the type information in order to correctly assign types to properties. When a type is not given, it applies json.RawMessage which makes handling very cumbersome. We almost always can specify a type, so when we can, we should.

I'll hang bugs off this with PRs for the fixes.

Comment 1

[Pete Moore [:pmoore][:pete]]

Oh boy, looks like we have 51 occurrences...

Comment 2

[Pete Moore [:pmoore][:pete]]

When I do this, I'll also add a test to the go client so we get notified as soon as new types get added that don't specify a type...

Alternatively we could enforce this via schema validation...

Comment 3

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-purge-cache

Comment 4

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-index

Comment 5

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-auth

Comment 6

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-queue

Comment 7

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for task-graph-scheduler

Comment 8

[Pete Moore [:pmoore][:pete]]

That's the lot - turned out to be less than 51 due to some duplication in the report I generated.

Thanks Jonas!

Comment 9

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8679590 [details] [review]
Github Pull Request for taskcluster-auth

Will rollout next I roll out something for auth...

Comment 10

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8679614 [details] [review]
Github Pull Request for taskcluster-queue

See issues on github PR...

Comment 11

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8679619 [details] [review]
Github Pull Request for task-graph-scheduler

landing this now..

Comment 12

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8679588 [details] [review]
Github Pull Request for taskcluster-index

Deployed...

Comment 13

[Pete Moore [:pmoore][:pete]]

Thanks for the reviews Jonas!

(In reply to Jonas Finnemann Jensen (:jonasfj) from comment #10)
> Comment on attachment 8679614 [details] [review]
> Github Pull Request for taskcluster-queue
> 
> See issues on github PR...

Thanks - and well spotted! I've incorporated the corrections you made - can you review again?

Comment 14

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8679614 [details] [review]
Github Pull Request for taskcluster-queue

(updating r- => r+ to reflect r+ in GitHub PR after incorporating fixes)

Comment 15

[Selena Deckelmann :selenamarie :selena]

Any more to do on this bug?

Comment 16

[Pete Moore [:pmoore][:pete]]

I think all is done. Thanks Selena for following up. =)