1218918 - devtools "work offline" does not work after real network interface is disabled and re-enabled

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Steps:

1) Enable "work offline" in devtools.
2) Note pages no longer can load from network.
3) Disable "work offline" in devtools.
4) Note pages can once again load from network.
5) Disable network interface (ethernet on my wind8.1 desktop machine)
6) Note pages no longer can load from network
7) Enable network interface
8) Note pages can once again load from network
9) Enable "work offline" in devtools

Expected:

After step 9, pages should be blocked from the network again.

Actual:

After step 9 I am able to load pages from the network even though "work offline" is checked.  Some time later, after leaving browser idle it begins blocking network again.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

By work offline, are we talking about the setting in the Firefox menu bar, or something inside the DevTools toolbox?

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> By work offline, are we talking about the setting in the Firefox menu bar,
> or something inside the DevTools toolbox?

I did Hamburger -> Developer -> Work Offline.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Ah okay, I did not realize it was shown there!  The DevTools has not done much with feature in the past.  It toggles `Services.io.workOffline`, and the behavior from there is managed by the networking code.

:mayhemer, do you know who could look into something like this?

Comment 4

[Honza Bambas (:mayhemer)]

Patrick, can you please forward to the right person?  Thanks.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Issues with devtools "work offline" when connectivity changes

* Flip the network.offline-mirrors-connectivity pref, so that ioservice.offline means the same as devtools work offline
* ioService.manageOfflineStatus shouldn't be changed when going to offline mode.
* Add logging to nsIOService in order to track offline/connectivity issues

Comment 6

[Valentin Gosu [:valentin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1464ef67f0f4

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8686597 [details] [diff] [review]
Issues with devtools "work offline" when connectivity changes

This bug occurs for 2 reasons:
1. network.offline-mirrors-connectivity was set to true, in order not to break previous assumptions about ioservice.offline. However, this led to the odd situation in which setting ioservice.offline to true did not always cause it to be true, because the getter also took connectivity into account.
2. when calling toggleOfflineStatus, it would set ioService.manageOfflineStatus to false, which effectively disables our connectivity detection. This should only be changed via the preference, if the user wants to do so.

Comment 8

[Patrick McManus [:mcmanus]]

Comment on attachment 8686597 [details] [diff] [review]
Issues with devtools "work offline" when connectivity changes

Review of attachment 8686597 [details] [diff] [review]:
-----------------------------------------------------------------

something about this makes me nervous, but I can't figure out what...

Comment 9

[Valentin Gosu [:valentin] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4d1f42f705eade8e9ac8511942aaab8e071f897
Bug 1218918 - Issues with devtools "work offline" when connectivity changes r=mcmanus,dao

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b4d1f42f705e