Closed Bug 1218957 Opened 9 years ago Closed 6 years ago

Check for import order automatically

Categories

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Product:
developer.mozilla.org Graveyard
Component:
Code Cleanup
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jezdez, Assigned: jwhitlock)

Details

(Whiteboard: [specification][type:change]) 

What feature should be changed? Please provide the URL of the feature if possible.
==================================================================================
There is a great tool called isort that allows checking for common types of import order pattern that I believe would help us keep the imports in Python sane.

What problems would this solve?
===============================
Less oddities and more best practices.

Who would use this?
===================
devs and Travis-CI

What would users see?
=====================
n/a

What would users do? What would happen as a result?
===================================================
n/a

Is there anything else we should know?
======================================
Assignee: nobody → jezdez
Status: NEW → ASSIGNED
Component: General → Code Cleanup
Assignee: jezdez → nobody
Status: ASSIGNED → NEW
We're looking at this again. A pyflakes plugin looks promising, and the cryptography style is my favorite:

https://github.com/PyCQA/flake8-import-order
Fixed April 2017 in https://github.com/mozilla/kuma/pull/4727, attached to bug 957802.
Assignee: nobody → jwhitlock
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.