1218967 - autospider.sh should not exit on test failure

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

autospider.sh executes several tests sequentially, and it exits if one of them fails.
for example, jstests won't be executed if jit-test fails.  it means we may miss the critical failure in jstests if intermittent failure happens in jit-test on TreeHerder.

it should be better to execute everything first, then do |exit 1| if some of them fails.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Do not stop executing autospider.sh on test failure.

I think |make check| won't hit intermittent failure and the failure there should be reported ASAP.
other 3 tests are now executed regardless of each test's result.
(not sure if there are/were intermittent failure in jsapi-tests tho)

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8679713 [details] [diff] [review]
Do not stop executing autospider.sh on test failure.

Review of attachment 8679713 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but I think we probably want to propagate the exit code a little better. Please replace all the

  RESULT=1

with

  RESULT=$?

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa8f6c1aa893ed085cfada7de6e7a6089b0f7409
Bug 1218967 - Do not stop executing autospider.sh on test failure. r=sfink

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fa8f6c1aa893