Closed Bug 1218967 Opened 7 years ago Closed 7 years ago

autospider.sh should not exit on test failure

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: arai, Assigned: arai)

Details

Attachments

(1 file)

autospider.sh executes several tests sequentially, and it exits if one of them fails.
for example, jstests won't be executed if jit-test fails.  it means we may miss the critical failure in jstests if intermittent failure happens in jit-test on TreeHerder.

it should be better to execute everything first, then do |exit 1| if some of them fails.
I think |make check| won't hit intermittent failure and the failure there should be reported ASAP.
other 3 tests are now executed regardless of each test's result.
(not sure if there are/were intermittent failure in jsapi-tests tho)
Assignee: nobody → arai.unmht
Attachment #8679713 - Flags: review?(sphink)
Comment on attachment 8679713 [details] [diff] [review]
Do not stop executing autospider.sh on test failure.

Review of attachment 8679713 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but I think we probably want to propagate the exit code a little better. Please replace all the

  RESULT=1

with

  RESULT=$?
Attachment #8679713 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/fa8f6c1aa893
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.