Closed Bug 1218981 Opened 9 years ago Closed 9 years ago

[mozdevice] Ensure adb.py methods propagate root to other called methods

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 affected, firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox44 --- affected
firefox45 --- fixed

People

(Reporter: bc, Assigned: bc)

Details

Attachments

(1 file)

bug-1211655.patch
1.99 KB, patch
gbrown
: review+
wlach
: feedback+
Details | Diff | Splinter Review 
In bug 1211655, I fixed the Autophone version of adb.py to properly propagate the root parameter to called methods. This just brings the patch over to mozdevice.
Attachment #8679645 - Flags: review?(gbrown)
Attachment #8679645 - Flags: feedback?(wlachance)
Submitted to try
try: -b o -p android-api-9,android-api-11,android-x86,emulator,linux64_gecko -u all -t none
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c174b59b32bb
Attachment #8679645 - Flags: review?(gbrown) → review+
try was broken due to leaving a file out of dave's patch.
new try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab2e418e2020
Attachment #8679645 - Flags: feedback?(wlachance) → feedback+
https://hg.mozilla.org/mozilla-central/rev/f24280e27cad
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: