[mozdevice] Ensure adb.py methods propagate root to other called methods

RESOLVED FIXED in Firefox 45

Status

Testing
Mozbase
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Trunk
mozilla45
Points:
---

Firefox Tracking Flags

(firefox44 affected, firefox45 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8679645 [details] [diff] [review]
bug-1211655.patch

In bug 1211655, I fixed the Autophone version of adb.py to properly propagate the root parameter to called methods. This just brings the patch over to mozdevice.
Attachment #8679645 - Flags: review?(gbrown)
Attachment #8679645 - Flags: feedback?(wlachance)
(Assignee)

Comment 1

2 years ago
Submitted to try
try: -b o -p android-api-9,android-api-11,android-x86,emulator,linux64_gecko -u all -t none
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c174b59b32bb

Updated

2 years ago
Attachment #8679645 - Flags: review?(gbrown) → review+
(Assignee)

Comment 2

2 years ago
try was broken due to leaving a file out of dave's patch.
new try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab2e418e2020
Attachment #8679645 - Flags: feedback?(wlachance) → feedback+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f24280e27cad

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f24280e27cad
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Comment 5

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f24280e27cad
status-b2g-v2.5: --- → fixed
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
You need to log in before you can comment on or make changes to this bug.