1219042 - Correct StrictMode violation work-around in FirefoxAccounts.getPickledAccount

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Currently, we throw the disk access onto a worker thread and wait for the worker thread to finish which defeats the purpose of doing the disc access on worker thread. We should correct this behavior by either:
  * Provide an async callback as a parameter to getPickledAccount and return immediately. Be sure to specify which thread the callback will run on.
  * Only run getPickledAccount and methods that call it on a background thread – be sure to make the correct annotation.
  * Not preferred: temporarily disable the StrictModeViolation and do it on the UI thread, avoiding the overhead of using the worker threads

This would be a good time to throw in some method-level threading annotations.

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.