Closed Bug 1219050 Opened 6 years ago Closed 6 years ago
ARM64: Update to VIXL 1
The attached patch updates our in-tree copy of VIXL from a hybrid of 1.2 and 1.3 to 1.10. The patch passes all tests that don't time out regularly, except for sunspider/check-bitops-nsieve-bits, which returns a garbage object from UnboxedLayout::makeConstructorCode(). Version 1.10 adds support for vector operations necessary for SIMD.js, and includes exclusive access simulation necessary for SharedArrayBuffer. I have attempted to carry over the changes made to VIXL in our tree during the update. Future updates should be easier to manage, since now that we have a set version, it will be easy to just update based on the diff.
Attachment #8679725 - Flags: review?(jolesen)
Mostly just as a note for myself: the problem with UnboxedLayout is likely that it doesn't save/restore LR on ARM/ARM64/MIPS, but calls allocateObject(). If the nursery happens to be full, we perform a call that clobbers LR.
Attachment #8679725 - Flags: review?(jolesen) → review+
I had to back this out for arm64 SM failures: https://treeherder.mozilla.org/logviewer.html#?job_id=16706323&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/7688ea495057
Clearing NI: crashes are addressed by a small patch to the (unused) "new" allocation, and by Bug 1222640.
You need to log in before you can comment on or make changes to this bug.