Closed
Bug 1219075
Opened 9 years ago
Closed 9 years ago
Enable Android lockscreen and disable Gaia lockscreen
Categories
(B2GDroid Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sgiles, Assigned: sgiles)
References
Details
Attachments
(1 file, 5 obsolete files)
|
2.27 KB,
patch
|
Details | Diff | Splinter Review |
Alternative to bug 1212535
|
||
Comment 1•9 years ago
|
||
Attachment #8679754 -
Flags: review?(fabrice)
Attachment #8679753 -
Flags: review?(fabrice)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8679753 [details] [review] [gaia] samgiles:disable-b2gdroid-lockscreen > mozilla-b2g:master I left a comment on github, but we need more: the full "lockscreen" panel in the settings app needs to disappear. That should be possible by using the preprocessor and an IFNDEF B2GDROID directive. All we need to figure out is how to set the B2GDROID environment variable.
Attachment #8679753 -
Flags: review?(fabrice) → review-
Comment on attachment 8679753 [details] [review] [gaia] samgiles:disable-b2gdroid-lockscreen > mozilla-b2g:master There already exists an "NO_LOCK_SCREEN" config variable. I'm going to (or will already have) update the other patch to add this to the Gaia build config for b2gdroid.
Attachment #8679753 -
Flags: review- → review?(fabrice)
Adds option for Gaia make to disable lock screen.
Attachment #8679754 -
Attachment is obsolete: true
Attachment #8679754 -
Flags: review?(fabrice)
Attachment #8680056 -
Flags: review?(fabrice)
Attachment #8679753 -
Flags: review?(fabrice)
Attachment #8679753 -
Attachment is obsolete: true
I've moved the settings into the one expression.
Attachment #8680143 -
Flags: review?(fabrice)
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8680143 [details] [diff] [review] enable-lockscreen.patch Review of attachment 8680143 [details] [diff] [review]: ----------------------------------------------------------------- This failed to build on linux: Makefile:17: *** unterminated call to function `if': missing `)'. Stop.
Attachment #8680143 -
Flags: review?(fabrice) → review-
|
|
||
Updated•9 years ago
|
Attachment #8680056 -
Flags: review?(fabrice)
|
|
||
Updated•9 years ago
|
Attachment #8680056 -
Attachment is obsolete: true
That was careless of me :|, sorry.
Attachment #8680143 -
Attachment is obsolete: true
Attachment #8680283 -
Flags: review?(fabrice)
|
|
||
Updated•9 years ago
|
Attachment #8680283 -
Flags: review?(fabrice) → review+
|
||
Comment 11•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6dade64276f4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 12•9 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6dade64276f4
status-b2g-v2.5:
--- → fixed
|
|
||
Comment 13•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•