Closed Bug 1219081 Opened 6 years ago Closed 4 years ago

Remove reference to libxul_sdk_includes from xpidl

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: iann_bugzilla, Assigned: mccr8)

References

(
URL
)

Details

Attachments

(1 file)

Bug 1219081 - Remove undefined reference to libxul_sdk_includes from XPIDL makefile.
59 bytes, text/x-review-board-request
glandium
: review+
Details 
Even though --with-libxul-sdk has been killed over in bug 1211765 there is still a reference to libxul_sdk_includes in the Makefile.in for xpidl, it should be removed.
URL: http://mxr.mozilla.org/mozilla-centra...
OS: Unspecified → All
Hardware: Unspecified → All
I noticed this, too. I confirmed locally that $(libxul_sdk_includes) evaluates to the empty string and checked that the build works. I can't imagine any more testing is needed.
Assignee: nobody → continuation
status-firefox44: affected → ---
Comment on attachment 8952563 [details]
Bug 1219081 - Remove undefined reference to libxul_sdk_includes from XPIDL makefile.

https://reviewboard.mozilla.org/r/221806/#review227738
Attachment #8952563 - Flags: review?(mh+mozilla) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b95d386bf5fc
Remove undefined reference to libxul_sdk_includes from XPIDL makefile. r=glandium
https://hg.mozilla.org/mozilla-central/rev/b95d386bf5fc
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.