Closed
Bug 1219081
Opened 10 years ago
Closed 7 years ago
Remove reference to libxul_sdk_includes from xpidl
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: mccr8)
References
()
Details
Attachments
(1 file)
Even though --with-libxul-sdk has been killed over in bug 1211765 there is still a reference to libxul_sdk_includes in the Makefile.in for xpidl, it should be removed.
|
Assignee | |
Comment 1•7 years ago
|
||
I noticed this, too. I confirmed locally that $(libxul_sdk_includes) evaluates to the empty string and checked that the build works. I can't imagine any more testing is needed.
Assignee: nobody → continuation
status-firefox44:
affected → ---
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8952563 [details]
Bug 1219081 - Remove undefined reference to libxul_sdk_includes from XPIDL makefile.
https://reviewboard.mozilla.org/r/221806/#review227738
Attachment #8952563 -
Flags: review?(mh+mozilla) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b95d386bf5fc
Remove undefined reference to libxul_sdk_includes from XPIDL makefile. r=glandium
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•