Remove unused functions from AbstractMediaDecoder

RESOLVED FIXED in Firefox 45

Status

()

Core
Audio/Video: Playback
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
AbstractMediaDecoder::NotifyDataArrived has no callers and can be removed. MediaDecoder::NotifyDataArrived has no overrides and can be devirtualized.
(Assignee)

Comment 1

2 years ago
Correction: MediaDecoder::NotifyDataArrived implements MediaResourceCallback and can't be devirtualized. We will remove AbstractMediaDecoder::NotifyDataArrived only.
Assignee: nobody → jwwang
Summary: Devirtualize MediaDecoder::NotifyDataArrived → Remove AbstractMediaDecoder::NotifyDataArrived
(Assignee)

Comment 2

2 years ago
In fact, we will clean up unused functions of AbstractMediaDecoder.
Summary: Remove AbstractMediaDecoder::NotifyDataArrived → Remove unused functions from AbstractMediaDecoder
Priority: -- → P2
(Assignee)

Comment 3

2 years ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d5376f96b4e
(Assignee)

Comment 4

2 years ago
Created attachment 8690610 [details]
MozReview Request: Bug 1219163. Part 1 - Remove unused functions from AbstractMediaDecoder. r=jya.

Bug 1219163. Part 1 - Remove unused functions from AbstractMediaDecoder. r=jya.
Attachment #8690610 - Flags: review?(jyavenard)
(Assignee)

Comment 5

2 years ago
Created attachment 8690611 [details]
MozReview Request: Bug 1219163. Part 2 - Move some functions that are never called from the interface of AbstractMediaDecoder down the class hierarchy. r=jya.

Bug 1219163. Part 2 - Move some functions that are never called from the interface of AbstractMediaDecoder down the class hierarchy. r=jya.
Attachment #8690611 - Flags: review?(jyavenard)
Comment on attachment 8690610 [details]
MozReview Request: Bug 1219163. Part 1 - Remove unused functions from AbstractMediaDecoder. r=jya.

https://reviewboard.mozilla.org/r/25879/#review23275
Attachment #8690610 - Flags: review?(jyavenard) → review+
Comment on attachment 8690611 [details]
MozReview Request: Bug 1219163. Part 2 - Move some functions that are never called from the interface of AbstractMediaDecoder down the class hierarchy. r=jya.

https://reviewboard.mozilla.org/r/25881/#review23277
Attachment #8690611 - Flags: review?(jyavenard) → review+
(Assignee)

Comment 8

2 years ago
Thanks for the review!

Comment 9

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebce560d20ac
https://hg.mozilla.org/integration/mozilla-inbound/rev/1911381f3f89

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ebce560d20ac
https://hg.mozilla.org/mozilla-central/rev/1911381f3f89
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.