1219163 - Remove unused functions from AbstractMediaDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

AbstractMediaDecoder::NotifyDataArrived has no callers and can be removed. MediaDecoder::NotifyDataArrived has no overrides and can be devirtualized.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Correction: MediaDecoder::NotifyDataArrived implements MediaResourceCallback and can't be devirtualized. We will remove AbstractMediaDecoder::NotifyDataArrived only.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

In fact, we will clean up unused functions of AbstractMediaDecoder.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d5376f96b4e

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1219163. Part 1 - Remove unused functions from AbstractMediaDecoder. r=jya.

Bug 1219163. Part 1 - Remove unused functions from AbstractMediaDecoder. r=jya.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1219163. Part 2 - Move some functions that are never called from the interface of AbstractMediaDecoder down the class hierarchy. r=jya.

Bug 1219163. Part 2 - Move some functions that are never called from the interface of AbstractMediaDecoder down the class hierarchy. r=jya.

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8690610 [details]
MozReview Request: Bug 1219163. Part 1 - Remove unused functions from AbstractMediaDecoder. r=jya.

https://reviewboard.mozilla.org/r/25879/#review23275

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8690611 [details]
MozReview Request: Bug 1219163. Part 2 - Move some functions that are never called from the interface of AbstractMediaDecoder down the class hierarchy. r=jya.

https://reviewboard.mozilla.org/r/25881/#review23277

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebce560d20ac
https://hg.mozilla.org/integration/mozilla-inbound/rev/1911381f3f89

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ebce560d20ac
https://hg.mozilla.org/mozilla-central/rev/1911381f3f89