Closed
Bug 1219165
Opened 10 years ago
Closed 10 years ago
NSS_ENABLE_WERROR=0 doesn't work on MSVC build
Categories
(NSS :: Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.21
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
mt
:
review+
mt
:
checked-in+
|
Details | Diff | Splinter Review |
Bug 1216318 adds NSS_ENABLE_WERROR to Linux.mk and Darwin.mk. But it doesn't support on MSVC build.
If this was supported, we could use workaround by NSS_ENABLE_WERROR=0. And I doesn't add local patch to build m-c even if nss that has bug 1218254's fix is synced into m-c.
|
Assignee | |
Updated•10 years ago
|
OS: Unspecified → Windows
Version: 3.21 → trunk
|
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → m_kato
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8679878 [details] [diff] [review]
Support NSS_ENABLE_WERROR=0 on MSVC build
Support NSS_ENABLE_WERROR=0 on Windows MSVC build to avoid warning-as-error by make option.
Attachment #8679878 -
Flags: review?(martin.thomson)
|
||
Updated•10 years ago
|
Attachment #8679878 -
Flags: review?(martin.thomson) → review+
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8679878 [details] [diff] [review]
Support NSS_ENABLE_WERROR=0 on MSVC build
Review of attachment 8679878 [details] [diff] [review]:
-----------------------------------------------------------------
https://hg.mozilla.org/projects/nss/rev/58362460084c
Attachment #8679878 -
Flags: checked-in+
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.21
You need to log in
before you can comment on or make changes to this bug.
Description
•