Closed Bug 1219168 Opened 9 years ago Closed 9 years ago

[Contacts]When user imports contacts from Gmail or Outlook, the loading progress bar is seperated from the header.

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 unaffected, b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g-v2.2 --- unaffected
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: liuke, Assigned: rakhavan)

Details

(Keywords: regression, Whiteboard: [2.5-aries-test-run-3])

Attachments

(5 files)

Bug log: logcat_1357.txt
234.93 KB, text/plain
Details
Video: Flame KK v2.5.3GP
2.32 MB, video/3gpp
Details
[gaia] jedireza:import-contacts-progress-bar > mozilla-b2g:master
46 bytes, text/x-github-pull-request
etienne
: review+
arcturus
: feedback+
Details | Review
Verify: Verified_FlameKK_v2.6.3GP
1.48 MB, video/3gpp
Details
Verify: Verified_FlameKK_v2.5.3GP
1.69 MB, video/3gpp
Details 
[1.Description]:
[Aires KKv2.5][Flame KK v2.5][Contacts]When user imports contacts from Gmail or Outlook, you can see the loading progress bar is seperated from the header.
See video:"Flame KK v2.5.3GP"
See log:"logcat_1357.txt"
Found time:13:57

[2.Testing Steps]: 
Precondition: Have an internet connection.
1.Launch the Contacts.
2.Select Settings and  click into "Import Contancts".
3.Select"Gmail"or "Outlook".

[3.Expected Result]: 
3.When loading, the progress bar should on the top of the header.

[4.Actual Result]: 
3.When loading, the progress bar is seperated from the header.

[5.Reproduction build]: 
Device: Aries KK 2.5 (Affected)
Build ID               20151027221526
Gaia Revision          a26eadc5e1133d5112b6cbc10badbb7670a1090f
Gaia Date              2015-10-27 17:36:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2b333a1d94e805a59c619ee41a6dec7fdcce505d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151027.213419
Firmware Date          Tue Oct 27 21:34:27 UTC 2015
Bootloader             s1

Device:FlameKK 2.5  (Affected)
 Build ID               20151027150240
Gaia Revision          a26eadc5e1133d5112b6cbc10badbb7670a1090f
Gaia Date              2015-10-27 17:36:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2b333a1d94e805a59c619ee41a6dec7fdcce505d
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151027.184038
Firmware Date          Tue Oct 27 18:40:49 EDT 2015
Firmware Version       v18D v4 
Bootloader             L1TC000118D0

Device:FlameKK v2.2  (Unaffected)
Build ID               20151027032504
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/05144e035522
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151027.065908
Firmware Date          Tue Oct 27 06:59:20 EDT 2015
Firmware Version       v18D v4 
Bootloader             L1TC000118D0


[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free test
QA Contact: jthomas
b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame KK v2.5
Build ID               20151025105432
Gaia Revision          8ea2ef2afbab48254feb808fa74b37f893082fdf
Gaia Date              2015-10-25 17:07:18
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/0c5087ec84356a980f3b260e8048edf3bb49dd77
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151025.201952
Firmware Date          Sun Oct 25 20:20:05 EDT 2015
Fireware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Build ID               20151025200834
Gaia Revision          3d2e28c2d7ce587626784ff291ce3b049f7d7d0a
Gaia Date              2015-10-26 02:39:32
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/8ecdbf67b2703d29263cd1d77773a98fc31ac596
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151025.201952
Firmware Date          Sun Oct 25 20:20:05 EDT 2015
Fireware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia Revision          3d2e28c2d7ce587626784ff291ce3b049f7d7d0a
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/0c5087ec84356a980f3b260e8048edf3bb49dd77

First Broken Gecko & Last Working Gaia – issue DOES NOT repro
Gaia Revision          8ea2ef2afbab48254feb808fa74b37f893082fdf
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/8ecdbf67b2703d29263cd1d77773a98fc31ac596

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/8ea2ef2afbab48254feb808fa74b37f893082fdf...3d2e28c2d7ce587626784ff291ce3b049f7d7d0a



Hi Reza,

    This bug is probably caused by Bug 1213894, could you help to check?  

Thank you very much.
QA Whiteboard: [MGSEI-Triage+]
Flags: needinfo?(rakhavan)
Keywords: regressionwindow-wanted → regression
Comment on attachment 8680502 [details] [review]
[gaia] jedireza:import-contacts-progress-bar > mozilla-b2g:master

Francisco, this should be quick a quick and easy review.

Tests are all green [1] and I tested locally to ensure this progress bar was fixed as well as the progress bar fix from bug 1213894 that introduced this regression are all working as expected.

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=62f1da75692aed2b72e8bee76691c71fa00dd57e
Flags: needinfo?(rakhavan)
Attachment #8680502 - Flags: review?(francisco)
Comment on attachment 8680502 [details] [review]
[gaia] jedireza:import-contacts-progress-bar > mozilla-b2g:master

LGTM, tried and working, but unfortunately I'm not a system peer so cannot grant the r+.

Forwarding to Etienne, Reza, if you know someone else that could do the r? please fill free to reassign.
Attachment #8680502 - Flags: review?(francisco)
Attachment #8680502 - Flags: review?(etienne)
Attachment #8680502 - Flags: feedback+
Assignee: nobody → rakhavan
Comment on attachment 8680502 [details] [review]
[gaia] jedireza:import-contacts-progress-bar > mozilla-b2g:master

lgtm :)
Attachment #8680502 - Flags: review?(etienne) → review+
Thanks!

On master:
https://github.com/mozilla-b2g/gaia/commit/c142625f70a2a1b6b3bda1aa979202a37cd08aa1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Hi Lance,

Please verify this bug, thanks.
Flags: needinfo?(liuke)
Keywords: verifyme
QA Whiteboard: [MGSEI-Triage+] → [QAnalyst-Triage+] [MGSEI-Triage+]
status-b2g-v2.5: --- → affected
status-b2g-master: affected → verified
Keywords: verifyme
Created attachment 8682946 [details]
Verify: Verified_FlameKK_v2.6.3GP

This bug has been verified as "pass" on the latest build of Aries KK v2.6 and Flame KK v2.6 512mb by the STR in comment 0.

Actual results: When user imports contacts from Gmail or Outlook, the progress bar is on the top of the header.
See attachment: Verified_FlameKK_v2.6.3GP
Reproduce rate: 0/10

Device: Aries KK 2.6 (master) (Pass)
Build ID               20151104004249
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151104.000116
Firmware Date          Wed Nov  4 00:01:24 UTC 2015
Bootloader             s1


Device: Flame KK 2.6 (master) 512mb (Pass)
Build ID               20151103150203
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.182550
Firmware Date          Tue Nov  3 18:26:03 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D
QA Whiteboard: [QAnalyst-Triage+] [MGSEI-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
Keywords: verifyme
Keywords: verifyme
Adding qawanted to this bug as not very sure about the status. It seems to be resolved and at some point verified but, I can reproduce the problem:

In Flame 2.5: 
BuildID: 20151004004502
Gaia: 91acc949
The progress bar is separated from the header, there are two progress bar, on top of the header and at the bottom

Not repro in Flame 2.6. 

As re-opening a bug is confusing, should we create a new bug to follow the status in 2.5, what do you think?
Thanks
Keywords: qawanted
(In reply to Isabel Rios from comment #11)
> Adding qawanted to this bug as not very sure about the status. It seems to
> be resolved and at some point verified but, I can reproduce the problem:
> 
> In Flame 2.5: 
> BuildID: 20151004004502
> Gaia: 91acc949
> The progress bar is separated from the header, there are two progress bar,
> on top of the header and at the bottom

Could you add a screenshot? Could this be from the recent "premature" branching?
Hi Isobel,
   According to comment 11, the fixed gaia date should be 2015-09-29(Date:   Thu Oct 29 22:05:57 2015 +0800), but the gaia date(91acc949) that you provided in comment 11 is 2015-08-28(Gaia Date   2015-10-28 20:32:15 +0800).  I'd appreciate that we should wait for the latest build to verify again.
Keywords: qawanted
Hi Lance,

Sorry, my bad, I will verify with newest gaia.
This issue has been verified as fixed on Aries 2.6 and Flame 2.5

The loading bar appears in the correct position above the header.

Device: Aries 2.6
Build ID: 20151106211009
Gaia: cec4c1d3729137a24163756d15f98b0d37803966
Gecko: 42627d5369b33828b16f6e7295796f0221b318a5
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/4

Device: Flame 2.5 (Full Flash)(KK)(512mb)
Build ID: 20151105004500
Gaia: 47da49f8206788d70d834c3a63d9245d50c89103
Gecko: 5c9fd135d4309239794126f1942d6e7aa8b3579c
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (This was the incorrect version)
Firmware Version: v18D v4
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][MGSEI-Triage+] → [QAnalyst-Triage?][MGSEI-Triage+]
status-b2g-v2.5: affected → verified
Please also see bug 1222192 This is also happening when opening the persona window in bugzilla lite.
Flags: needinfo?(jmercado)
QA Whiteboard: [QAnalyst-Triage?][MGSEI-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
Flags: needinfo?(jmercado)
This bug has been verified as "pass" on the latest build of Aries KK v2.5 by the STR in comment 0

Actual results: When user imports contacts from Gmail or Outlook, the progress bar is on the top of the header.
See attachment: Verified_FlameKK_v2.5.3GP
Reproduce rate: 0/10

Device: Aries KK 2.5 (Pass)
Build ID               20151107112205
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151107.104119
Firmware Date          Sat Nov  7 10:41:27 UTC 2015
Bootloader             s1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: