Make test_marketplace_addon.py work again

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Martijn Wargers (dead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Marketplace-Dev has been updated, which causes the test to still fail after bug 1218105 has been fixed.

This bug covers the fixing on this test.

Mathieu, the statusbar has been refactored (bug 1179723), I guess that made the 'M' in Status Bar add-on stop working.
Could you perhaps fix that and upload it to Marketplace-Dev?
Flags: needinfo?(mpillard)
(Assignee)

Comment 1

2 years ago
Ok, just got confirmation from Mathieu that he was planning on fixing it.
Flags: needinfo?(mpillard)
Created attachment 8679929 [details] [review]
[gaia] mwargers:1219191 > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Attachment #8679929 - Flags: review?(npark)
Attachment #8679929 - Flags: review?(jlorenzo)
(Assignee)

Updated

2 years ago
Attachment #8679929 - Flags: review?(npark)
Attachment #8679929 - Flags: review?(jlorenzo)
(Assignee)

Comment 3

2 years ago
Comment on attachment 8679929 [details] [review]
[gaia] mwargers:1219191 > mozilla-b2g:master

This makes us go directly go to the Add-on page, instead of doing the fragile enabling add-on, finding the correct add-on, etc.
This test is for making sure that installing an add-on from the Marketplace works correctly, so I don't this removal is bad.
Attachment #8679929 - Flags: review?(npark)
Attachment #8679929 - Flags: review?(jlorenzo)
Comment on attachment 8679929 [details] [review]
[gaia] mwargers:1219191 > mozilla-b2g:master

Looks good to me, I see now that switch_to_marketplace() should be a separate call.
Attachment #8679929 - Flags: review?(npark) → review+
Comment on attachment 8679929 [details] [review]
[gaia] mwargers:1219191 > mozilla-b2g:master

Having this shortcut takes us away from what a user would do, but I believe it's fine, until Marketplace finalize their workflow.
Attachment #8679929 - Flags: review?(jlorenzo) → review+
Note that the workflow on Marketplace dev at the moment is the final one. But to test it, you have to keep in mind that:
- We need to detect addons feature to show/hide the menu item. This is done using hasFeature(), which is, sadly, a privileged API. So this can only be done from inside the app (or need an override, the :debug button)
- Our dev server is just that: a development server, not meant to be stable, with no guarantees that data uploaded there will stay there forever
- Similarly, test data is uploaded to dev all the time, polluting search results

You could still make a test searching for a specific add-on and clicking on it if that's what you want - you just need to make sure you're clicking on the right one, possibly requiring you to a) verify that the addon is still there b) scroll down a lot (clicking the "load more" button) if there is more than one page of results).
(Assignee)

Comment 7

2 years ago
(In reply to Mathieu Pillard [:mat] from comment #6)
Yeah, I'm not so interested if the Marketplace-Dev UI is working, this test is mainly to test if installing an add-on is working.
Krupa told me to use Dev, because otherwise install statistics on Marketplace for that app would be skewed or something like that.
Fair enough. If you only truly care about installing an addon then dev is fine (provided you have certs/prefs correctly set to be able to install it).
(Assignee)

Comment 9

2 years ago
I removed this part of the pull request also:
+        self.keyboard.dismiss()
+        self.switch_to_marketplace()
This change I made wasn't necessary anymore and it caused a failure in test_marketplace_packaged_app.py anyhow.

Merged: https://github.com/mozilla-b2g/gaia/commit/9be6c4e179f8a6a2dc49b5e09e3a3c1c9ec4fc36
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.