Fix a wrong comment in BackgroundHangMonitor.h

RESOLVED FIXED in Firefox 45

Status

()

Toolkit
Telemetry
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

(Blocks: 1 bug)

Trunk
mozilla45
Points:
1

Firefox Tracking Flags

(firefox44 affected, firefox45 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In bug 1215466 comment 8 we found that the comment in [0] is wrong. We should change 

"The background hang monitor is responsible for detecting and reporting hangs in background (non-main) threads."

to

"The background hang monitor is responsible for detecting and reporting hangs in main and background threads."

[0] - https://dxr.mozilla.org/mozilla-central/rev/6c7c983bce46a460c2766fbdd73283f6d2b03a69/xpcom/threads/BackgroundHangMonitor.h#29
(Assignee)

Updated

2 years ago
Assignee: nobody → alessio.placitelli
Blocks: 1201022
Points: --- → 1
Priority: -- → P1
Whiteboard: [measurement:client]
(Assignee)

Comment 1

2 years ago
Created attachment 8679984 [details] [diff] [review]
bug1219216.patch
Attachment #8679984 - Flags: review?(gfritzsche)
Attachment #8679984 - Flags: review?(gfritzsche) → review?(vladan.bugzilla)
Comment on attachment 8679984 [details] [diff] [review]
bug1219216.patch

Review of attachment 8679984 [details] [diff] [review]:
-----------------------------------------------------------------

Nevermind, this is clear from bug 1215466.
Attachment #8679984 - Flags: review?(vladan.bugzilla) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/982da54f6ece66ff5a90fd4151f6a77d08dd58e8
Bug 1219216 - Fix a wrong comment in BackgroundHangMonitor.h. r=gfritzsche

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/982da54f6ece
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Comment 5

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/982da54f6ece
status-b2g-v2.5: --- → fixed
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
You need to log in before you can comment on or make changes to this bug.