Support add/remove Search provider via addon

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Browser
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: gasolin, Unassigned)

Tracking

({feature, foxfood})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
As a developer I'd like to add/remove search provider (wikipedia, google translate..) through addon.


In experiment, shared/js/SearchProvider.js will load json file and save the result in SearchProvider providers variable and mozSettings. Addon could change mozSettings but can't change the SearchProvider `providers` variable.

To make Search Providers list properly, we could add addProvider/removeProvider method in SearchProvider.js
(Reporter)

Updated

2 years ago
Summary: Support add/remove Search provider as addon → Support add/remove Search provider via addon
Created attachment 8679985 [details] [review]
[gaia] gasolin:master > mozilla-b2g:master
(Reporter)

Comment 2

2 years ago
Comment on attachment 8679985 [details] [review]
[gaia] gasolin:master > mozilla-b2g:master

Dale or Ben, 

I'd like to hear your feedback if its the right approach to add Search Provider. Then I'll add test cases and make sure it works with real addon (the addon needs update mozSettings search providers and call SearchProvider.addProvider on search app to make it works).

I found SearchProvider.ready() will return readyPromise early when it ran once.
It might possible to just add a `forceReload` parameter in SearchProvider.ready() to force reload addons from settings.
Attachment #8679985 - Flags: feedback?(dale)
Attachment #8679985 - Flags: feedback?(bfrancis)
Comment on attachment 8679985 [details] [review]
[gaia] gasolin:master > mozilla-b2g:master

Hi Fred,

I think it's fine if people want to and are able to create addons which add additional search engines if that's possible without modifying the search app too much.

However, we have plans to add native support for adding additional search engines to the search app and UX are currently working on some ideas for how this might work.

I agree this is a crucial piece of functionality but I think we can add general support for any Open Search provider without requiring an addon per provider.

Thanks
Attachment #8679985 - Flags: feedback?(bfrancis) → feedback-
(Reporter)

Comment 4

2 years ago
Comment on attachment 8679985 [details] [review]
[gaia] gasolin:master > mozilla-b2g:master

It's great to hear we are trying to address this issue. 

Will set this as wontfix if we can provide a more concrete plan.
Attachment #8679985 - Flags: feedback?(dale)
(Reporter)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.