JavaScript strict warning, cleanup of contentAreaClick.js

VERIFIED FIXED in mozilla0.9.9

Status

SeaMonkey
Tabbed Browser
P4
normal
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: WeirdAl, Assigned: Christopher Aillon (sabbatical, not receiving bugmail))

Tracking

Trunk
mozilla0.9.9

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

17 years ago
Warning: redeclaration of var loadInBackground
Source File: chrome://communicator/content/contentAreaClick.js
Line: 227, Column: 14
Source Code:
          var loadInBackground = pref.getBoolPref("browser.tabs.loadInBackground");

This was caused by caillon's patch in bug 113072.  Patch for that coming up in a
few minutes.
(Reporter)

Comment 1

17 years ago
Reassigning to caillon as requested.  I have a patch for the strict warning
coming up in a few seconds.
Assignee: jaggernaut → caillon
Summary: JavaScript strict warning in contentAreaClick.js → JavaScript strict warning, cleanup of contentAreaClick.js
(Reporter)

Comment 2

17 years ago
Created attachment 66529 [details] [diff] [review]
patch for strict warning
Comment on attachment 66529 [details] [diff] [review]
patch for strict warning

no, I need to remove that variable as jag and I have talked about.  The nifty
patch I had on bug 113072 is closer to what this should be.

aside from that, if I weren't going to remove this var, this is still the wrong
way to fix this.  The variable should be declared before the switch, really,
not like this.	I'll add  a patch to this shortly.
Attachment #66529 - Flags: needs-work+
Status: NEW → ASSIGNED
OS: Windows 98 → All
Priority: -- → P4
Hardware: PC → All
Target Milestone: --- → mozilla0.9.9
Created attachment 70465 [details] [diff] [review]
Remove strict warn
Attachment #66529 - Attachment is obsolete: true

Comment 5

17 years ago
Comment on attachment 70465 [details] [diff] [review]
Remove strict warn

sr=jag
Attachment #70465 - Flags: superreview+

Comment 6

17 years ago
Comment on attachment 70465 [details] [diff] [review]
Remove strict warn

r=walk84
Attachment #70465 - Flags: review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
no longer see this js strict warning... tested with 2002.07.23-1.0 bits.
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.