121922 - JavaScript strict warning, cleanup of contentAreaClick.js

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect, P4)

Description

[Alex Vincent [:WeirdAl]]

Warning: redeclaration of var loadInBackground
Source File: chrome://communicator/content/contentAreaClick.js
Line: 227, Column: 14
Source Code:
          var loadInBackground = pref.getBoolPref("browser.tabs.loadInBackground");

This was caused by caillon's patch in bug 113072.  Patch for that coming up in a
few minutes.

Comment 1

[Alex Vincent [:WeirdAl]]

Reassigning to caillon as requested.  I have a patch for the strict warning
coming up in a few seconds.

Comment 2

[Alex Vincent [:WeirdAl]]

Attachment: patch for strict warning

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 66529 [details] [diff] [review]
patch for strict warning

no, I need to remove that variable as jag and I have talked about.  The nifty
patch I had on bug 113072 is closer to what this should be.

aside from that, if I weren't going to remove this var, this is still the wrong
way to fix this.  The variable should be declared before the switch, really,
not like this.	I'll add  a patch to this shortly.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Remove strict warn

Comment 5

[jag (Peter Annema)]

Comment on attachment 70465 [details] [diff] [review]
Remove strict warn

sr=jag

Comment 6

[Stephen Walker]

Comment on attachment 70465 [details] [diff] [review]
Remove strict warn

r=walk84

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fix checked in.

Comment 8

[sairuh (rarely reading bugmail)]

no longer see this js strict warning... tested with 2002.07.23-1.0 bits.