Closed Bug 1219234 Opened 9 years ago Closed 9 years ago

The MozSpeech Benchmark app icon is blurry

Categories

(Firefox OS Graveyard :: Gaia::VoiceControl, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S11 (13Nov)

People

(Reporter: gmarty, Assigned: gmarty)

Details

Attachments

(1 file)

I know this is not a user facing app, but the icon of the MozSpeech app looks really bad, when compared to the rest of the default apps in Spark.
Also, in the app, an old version of the logo of Firefox is used.
Comment on attachment 8679994 [details] [review]
[gaia] gmarty:Bug-1219234-The-MozSpeech-Benchmark-app-icon-is-blurry > mozilla-b2g:master

Hey Andre, can you review this pull request (there's no code change) or should I do it to https://github.com/andrenatal/mozspeechcollect?
I reworked the icon in SVG so we can easily change it later if we want. I regenerated the icons and updated the Firefox logo.
Attachment #8679994 - Flags: review?(anatal)
Assignee: nobody → gmarty
Attachment #8679994 - Flags: review?(anatal) → review+
 (In reply to Guillaume Marty [:gmarty] from comment #2)
> Comment on attachment 8679994 [details] [review]
> [gaia] gmarty:Bug-1219234-The-MozSpeech-Benchmark-app-icon-is-blurry >
> mozilla-b2g:master
> 
> Hey Andre, can you review this pull request (there's no code change) or
> should I do it to https://github.com/andrenatal/mozspeechcollect?
> I reworked the icon in SVG so we can easily change it later if we want. I
> regenerated the icons and updated the Firefox logo.

Thanks for that Guillaume, it's amazing. Do you mind creating a PR in https://github.com/andrenatal/mozspeechcollect too?
Thanks for the r+. The pull request to the original repo is there: https://github.com/andrenatal/mozspeechcollect/pull/8
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/8154a4077ab5a7ece6322edba075a005bce3db8c
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: