use newtab.svg instead of GTK moz-icon on new tab button

NEW
Unassigned

Status

()

3 years ago
3 years ago

People

(Reporter: lasneolivier, Unassigned)

Tracking

41 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8680009 [details]
Firefox-symbolic-icon-bug.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20151015172900



Actual results:

On GNU/Linux, Firefox seems to use the add.svg icon.
This make Firefox look a little bit awkward on elementary OS.


Expected results:

Firefox should use the tab-new-symbolic.svg.
This change would make Firefox feel more integrated and coherent on GNU/Linux.

Linked a screenshot on elementary OS with side by side Firefox and Midori for comparison of the icons. Midori use tab-new-symbolic.

Updated

3 years ago
Component: Untriaged → Widget: Gtk
Product: Firefox → Core
I looked at https://github.com/GNOME/gnome-icon-theme-symbolic/blob/master/README but I don't really understand the distinction between tab-new-symbolic and tab-new.

Neither of these are in http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html so I don't know what defines what icons can be expected to be available.
Component: Widget: Gtk → Theme
Product: Core → Firefox
(Reporter)

Comment 2

3 years ago
I have done a some research and here is what I have found.

Symbolic icons are monochrome or low color version of other icons. They are used for common actions and indicators. Symbolic icons are optionals in icons themes and trying to load them if they are absent will fall back to regular icons.

I don't have experience in the development of gtk applications but I believe that's the function used to load symbolic icons.
https://developer.gnome.org/gtk3/stable/GtkIconTheme.html#gtk-icon-info-load-symbolic

Other links :
https://wiki.gnome.org/Design/OS/SymbolicIcons
https://web.archive.org/web/20130330075113/http://www.freedesktop.org/wiki/SymbolicIcons
Summary: use symbolic icon for new tab on GNU/Linux → use newtab.png instead of GTK mox-icon on new tab button
(gah, submitted too soon)

I think we should actually just use an icon from the Firefox theme here, instead of trying to use a native GTK icon. This ensures the icons in primary UI match what's expected, and is consistent with our general shift away from native icon when they need to integrate with the rest of our theme (because they're frequently ugly or stick out, due to the plethora of native icons that different desktops are using).
Summary: use newtab.png instead of GTK mox-icon on new tab button → use newtab.png instead of GTK moz-icon on new tab button
(In reply to Justin Dolske [:Dolske] from comment #3)
> (gah, submitted too soon)
> 
> I think we should actually just use an icon from the Firefox theme here,
> instead of trying to use a native GTK icon. This ensures the icons in
> primary UI match what's expected, and is consistent with our general shift
> away from native icon when they need to integrate with the rest of our theme
> (because they're frequently ugly or stick out, due to the plethora of native
> icons that different desktops are using).

Agreed. If we are using mostly custom icons in the primary chrome we should just use all custom icons for consistency and predictability. I think this and the dropdown arrow are the last GTK moz-icon we are using in the primary browser window chrome.

We will probably need to use an SVG icon here though. So we can pickup the right color. Like we do for close: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/icons/close.svg?raw=1
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: use newtab.png instead of GTK moz-icon on new tab button → use newtab.svg instead of GTK moz-icon on new tab button
You need to log in before you can comment on or make changes to this bug.