1219250 - [NGA] Search field should match latest visual spec

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Wilson Page [:wilsonpage]]

The current search field is left over from OGA and needs updating to match the latest visual spec [1].

[1] https://mozilla.app.box.com/s/fjqh6fjpwnsm427wl6yn6qtpyzxqbwgn

Comment 1

[Wilson Page [:wilsonpage]]

Depends on:

- https://github.com/gaia-components/gaia-fast-list/pull/39
- https://github.com/gaia-components/gaia-fast-list/pull/38

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1219250 > mozilla-b2g:master

Comment 3

[Hung Nguyen]

Comment on attachment 8682567 [details] [review]
[gaia] wilsonpage:1219250 > mozilla-b2g:master

Looks good.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8682567 [details] [review]
[gaia] wilsonpage:1219250 > mozilla-b2g:master

Overall looks good and I like that you've DRYed up the search/list setup into the base View class. However, there were a lot of nits and inconsistencies in this patch that go against the rest of the Music codebase in terms of coding style/conventions. Re-flag me for review after you've addressed my comments in the PR. Thanks!

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8682567 [details] [review]
[gaia] wilsonpage:1219250 > mozilla-b2g:master

LGTM. Left a few minor nits in the PR.

Comment 6

[Wilson Page [:wilsonpage]]

Comment on attachment 8682567 [details] [review]
[gaia] wilsonpage:1219250 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/commit/8bbe7157509f7128f49e52ffda6c6fd262c88c05

Comment 7

[Wilson Page [:wilsonpage]]

Comment on attachment 8682567 [details] [review]
[gaia] wilsonpage:1219250 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Search broken
[Testing completed]: Y
[Risk to taking this patch] (and alternatives if risky):
[String changes made]: N

Comment 8

[Mahendra Potharaju [:mahe]]

Comment on attachment 8682567 [details] [review]
[gaia] wilsonpage:1219250 > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 9

[SandKing]

Attachment: Bug video: Aries_v2.6.3GP

This bug has been verified as pass on latest Flame master and Aries KK master.
STR:
1. Launch "Music".
2. Wirh device in Music homescreen, Then scroll down the page to invoke search bar.
3. Input some keywords which matched with some songs.
4. Erase some words.

Actual result:
4. The music search list will update timely.

Reproduce rate: 0/10.
See video: "Aries_v2.6.3gp".

Device info:
Flame master 512M(Pass)
Build ID               20151119224634
Gaia Revision          94a821b49f4dca3f9321cd80e13c44c4a6696952
Gaia Date              2015-11-19 15:35:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc325db44f6f8a58604d60b746c140e73f3d8216
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151119.220436
Firmware Date          Thu Nov 19 22:04:46 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Aries KK master(Pass):
Build ID               20151120061630
Gaia Revision          94a821b49f4dca3f9321cd80e13c44c4a6696952
Gaia Date              2015-11-19 15:35:33
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3835b568092ae3b71adc931d24928670ad7141a7
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151120.052332
Firmware Date          Fri Nov 20 05:23:39 UTC 2015
Bootloader             s1

Comment 10

[SandKing]

Accordding to comment 8, add  "affected" tracking flag to "status-b2g-v2.5"

Comment 11

[Carsten Book [:Tomcat]]

landed on 2.5 as https://github.com/mozilla-b2g/gaia/commit/6391c98a943ef4a7500fbee54080640d975d67bf

Comment 12

[SandKing]

This bug has been verified as pass on latest Flame v2.5 and Aries KK v2.5.
STR:
same STR and actual result as comment 9.

Reproduce rate: 0/10.

Flame v2.5(pass):
Build ID               20151126113148
Gaia Revision          34ccc2c8f17b87a1fab95a4186b0019ec78c7f75
Gaia Date              2015-11-26 09:44:10
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fbaba398bd98fd1837ef2fd7c13ed8ee69640cfb
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151126.104320
Firmware Date          Thu Nov 26 10:43:29 UTC 2015
Bootloader             L1TC000118D0

Aries KK v2.5(pass):
Build ID               20151126113601
Gaia Revision          34ccc2c8f17b87a1fab95a4186b0019ec78c7f75
Gaia Date              2015-11-26 09:44:10
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fbaba398bd98fd1837ef2fd7c13ed8ee69640cfb
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151126.104443
Firmware Date          Thu Nov 26 10:44:51 UTC 2015
Bootloader             s1