121926 - email does not ask for password if it has the wrong one

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect)

Description

[Judd Rogers]

I started mailNews for the first time with build 20011122106. I normally use
netscape 4.7. mailNews picked up all the accounts just fine but got the wrong
password. mailNews tells me it can't log on to the mail server -- does this
twice. Never asks for the password.

After mailNews shuts up I click on some mail folder other than inbox and
mailNews asks for the password. All is right with the world.

Comment 1

[Reinout van Schouwen]

Confirmed on build 2002020516 (Solaris moz0.9.8).
This may be related to bug 63633.

Because of this problem, I went to the Password Manager just to find that it had
only web passwords and not email passwords listed! Looks like a 1.0 stopper to me...

Comment 2

[Russ Alman]

I believe I am seeing the same bug in Mac OS X build 2002030108.  I am having
this problem with an IMAP account.  I entered the wrong password, and now do not
get a prompt to re-enter -- I get a sheet (dialog) that says the login failed. 
This repeats 4 times, and then stops.  I never get a chance to re-enter the
password.

Comment 3

[Koike Kazuhiko]

I can reproduce this bug with 2002032921/Linux. Confirming.

Comment 4

[Thomas List]

I can reproduce this with Windows 2000, build 2002041711, and a pop account. The
exact answer trying to get the mail is:

The PASS command did not succeed. Mail server <servername> responded: [AUTH]
Password supplied for "<username>" is incorrrect.

Up to now I did not find a way to reenter the password. I think this is a very
serious bug!

Comment 5

[Peter Asemann]

Doesn't this look like bug #94775?

Comment 6

[Mitchell Stoltz (not reading bugmail)]

*** Bug 138815 has been marked as a duplicate of this bug. ***

Comment 7

[R.K.Aa.]

*** Bug 139679 has been marked as a duplicate of this bug. ***

Comment 8

[R.K.Aa.]

*** Bug 133851 has been marked as a duplicate of this bug. ***

Comment 9

[R.K.Aa.]

this is not only imap

Comment 10

[R.K.Aa.]

*** Bug 139819 has been marked as a duplicate of this bug. ***

Comment 11

[R.K.Aa.]

In just a couple of days these bugs bave been filed on the issue:
bug 138815, bug 139679, bug 133851, bug 139819, bug 139973 and bug 139981

Some are POP issues. The timespan between this bug being reported, and the "new
ones" - and not least the amount of them, may indicate a newer regression than
this bug? It's becoming a major problem and usability issue, as some users now
have to kill mozilla to get out of the loop.

Comment 12

[Oliver Klee]

*** Bug 142486 has been marked as a duplicate of this bug. ***

Comment 13

[Craig Ringer]

Confirm with Debian woody/i386 mozilla build 0.9.9-4 (old-ish, I know...)
exactly as described in #4.
If the mozilla is told to remember the password, it will never ask for it even
when it is incorrect.

The password _is_ listed in password manager, so suggested workaround is delete
password from password manager and either (1) don't use remember password or (2)
be very sure you type it right.

Also confirm exact same problem with rc1 off mozilla.org

Comment 14

[Robert Hershberger]

  I can confirm this bug is still alive and well in build number 2002051104.  I
had to delete the entry from the Password Manager before it would even ask me
for a new password.  And even after I had entered the new password, I needed to
shut down the mail client (left hand pressing return -- to clear the error
message, right clicking the mouse keys franticly)  before it would work.  This
bug cropped up after several weeks of error free computing, where in I connecte
daily to my ISP's mail server.

Comment 15

[R.K.Aa.]

*** Bug 145125 has been marked as a duplicate of this bug. ***

Comment 16

[Navin Gupta]

I believe all these are dups pop/imap. I'm working on it. 

Comment 17

[Navin Gupta]

*** Bug 140274 has been marked as a duplicate of this bug. ***

Comment 18

[Navin Gupta]

This was a regression caused bug bug 113540. The fix is to make sure we are
creating services for password manager category. One of the services is
nsIWalletService that needs to be created for mailnews passwords to work correctly. 
patch upcoming that does this. 

Comment 19

[Navin Gupta]

Attachment: proposed fix

See last comment by me for an explanation of the fix.

Comment 20

[Navin Gupta]

David, can I get r=? thx. 

Comment 21

[David :Bienvenu]

how come the wallet service isn't loaded as a result of getting the password out
of it to send to the server in the first place? 

Comment 22

[Navin Gupta]

Because it doesn't need walletService, we use nsIAuthPrompter. 

Comment 23

[Navin Gupta]

Attachment: better patch

We can pass nsnull for origin to NS_CreateServices... because it doesn't use
it.

Comment 24

[David :Bienvenu]

I don't understand. So we don't need the wallet service to retrieve passwords
from the password manager, but we need the wallet service when a logon fails? 

Comment 25

[David :Bienvenu]

I see that there's other code doing this (the forms code). It still seems weird.
In any case, could you actually check the return value of
CreateServicesForPasswordManager(and return the result of
NS_CreateServicesFromCategory...)

Comment 26

[Navin Gupta]

Most of the times the passwords are stored and we don't create WalletService if
we are successful in logging in. That is what happens most of the time. If the
stored passwords fail because the password has been changed using some other
client or like yahoo pop3 server is denying access to foreign clients, then 
we need to create wallet service for "login-failed" notification. Other
interfaces are used, I have seen in the debugger singsign etc.

They (performance grp) made walletService to be created lazily because of
start-up performance and they added RegisterProc and UnregisterProc to
WalletService for this to happen dynamically, like from form manager.

Comment 27

[Navin Gupta]

Attachment: patch -checking for return code

Comment 28

[David :Bienvenu]

Comment on attachment 84360 [details] [diff] [review]
patch -checking for return code

r=bienvenu

Comment 29

[David :Bienvenu]

Comment on attachment 84360 [details] [diff] [review]
patch -checking for return code

r=bienvenu

Comment 30

[Scott MacGregor]

Comment on attachment 84360 [details] [diff] [review]
patch -checking for return code

I'm worried about the static global variable. Recently those have been causing
trouble for issues like turbo where a restart doesn't cause static variables to
get cleared out. Will that be a problem here?

Comment 31

[Navin Gupta]

That should be okay here because we don't release/free services on turbo exit. 

Comment 32

[Scott MacGregor]

I was under the impression that some services like wallet in particular which
cache security information are cleared out over session-logout's..

Comment 33

[Navin Gupta]

good point, let me verify. 

Comment 34

[Navin Gupta]

We are not releasing walletService on turbo exit. I have seen this in debugger
and also if you look at nsWalletLibService::Observer, it doesn't listen for
"session-logout" topic. Even it holds cache security information it will have to
just clear out on session-logout topic, but the service will still be there.
There is no need to free service from security point of view, IMO. 

Comment 35

[Scott MacGregor]

Comment on attachment 84360 [details] [diff] [review]
patch -checking for return code

thanks for investigating Navin.

sr=mscott

Comment 36

[Navin Gupta]

fixed. 

Comment 37

[R.K.Aa.]

*** Bug 146323 has been marked as a duplicate of this bug. ***

Comment 38

[R.K.Aa.]

*** Bug 139981 has been marked as a duplicate of this bug. ***

Comment 39

[R.K.Aa.]

*** Bug 146961 has been marked as a duplicate of this bug. ***

Comment 40

[R.K.Aa.]

*** Bug 146961 has been marked as a duplicate of this bug. ***

Comment 41

[scottputterman]

Not being able to re-enter a password was showing up as a top issue from PR1.

Comment 42

[scottputterman]

adding adt1.0.1+ for checkin to the 1.0 branch.  Please get drivers approval
before checking in.  David, would you be able to ask for drivers approval and
land this if it's given?

Comment 43

[Judson Valeski]

please checkin to the 1.0.1 branch ASAP, and replace the mozilla1.0.1+ bug with
fixed1.0.1 once it's landed there.

Comment 44

[David :Bienvenu]

fix checked into 1.01 branch

Comment 45

[R.K.Aa.]

*** Bug 147872 has been marked as a duplicate of this bug. ***

Comment 46

[Andrew Hagen]

*** Bug 138801 has been marked as a duplicate of this bug. ***

Comment 47

[Andrew Hagen]

*** Bug 138815 has been marked as a duplicate of this bug. ***

Comment 48

[Jim Coleman]

It looks like this bug has been marked as fixed, correct me if I'm wrong. I just
need to let everyone know that my problem is NOT fixed and I still cannot use
Mozilla mail (I've been using Pegasus 4.01 since first reporting my problem).

To reiterate my problem:

When I try to send mail, Mozilla prompts me over and over and over again for my
SMTP password. It'll keep requesting it for as long as I care to type it in and
hit enter.

When I finally give up, I get a window displaying the following obvious message:

"Sending of message failed.

The message could not be sent because connecting to the SMTP server failed. The
server may be unavailable or is refusing SMTP connections. Please verify that
your SMTP server setting is correct and try again, or else contact your network
administrator."

This behavior started right around the time Mozilla 9.9 came out though I cannot
be more specific than that. I know it was right around the end of February so if
that is when Mozilla released the new 9.9 version, that is when it began.

I've changed my password several times trying to find a work around to no avail.
Pegasus works fine and is a very nice app but it's not what I'd prefer to use if
I had a choice. Hopefully, someone can track this down and fix it soon.

P.S.: I'm running release candidate #3 now.

Comment 49

[Andrew Hagen]

*** Bug 140403 has been marked as a duplicate of this bug. ***

Comment 50

[Andrew Hagen]

*** Bug 142787 has been marked as a duplicate of this bug. ***

Comment 51

[Andrew Hagen]

*** Bug 129085 has been marked as a duplicate of this bug. ***

Comment 52

[Andrew Hagen]

The fix is apparently checked into 1.0.1, but not 1.0. It's likely that once you
install 1.0.1, your SMTP problem will be fixed. If not, please post another
comment here. 

Comment 53

[Andrew Hagen]

*** Bug 127855 has been marked as a duplicate of this bug. ***

Comment 54

[Andrew Hagen]

*** Bug 148293 has been marked as a duplicate of this bug. ***

Comment 55

[Andrew Hagen]

*** Bug 148237 has been marked as a duplicate of this bug. ***

Comment 56

[Andrew Hagen]

*** Bug 145627 has been marked as a duplicate of this bug. ***

Comment 57

[Andrew Hagen]

*** Bug 134578 has been marked as a duplicate of this bug. ***

Comment 58

[scottputterman]

marking fixed again based on comments that RC3 was being used whereas this was
landed in 1.0.1 and the trunk.

Comment 59

[Ere Maijala (slow)]

Besides Jim said that Mozilla prompts for the password... 

Comment 60

[Andrew Hagen]

Proposed relnote: If a user types in a wrong password for e-mail and stores the
wrong password in password manager, Mozilla will not prompt the user to type in
a new, correct password. Workaround: go to Edit | Preferences | Privacy &
Security | Passwords | Manage Stored Passwords. Remove the appropriate entries
for the mail servers. Then, the next time the user accesses e-mail, he will be
prompted for a new password. This problem is fixed in Mozilla version 1.0.1.

Comment 61

[Andrew Hagen]

*** Bug 146332 has been marked as a duplicate of this bug. ***

Comment 62

[Jim Coleman]

I'll wait to see what comes with version 1.0.1 but most of the comments here
bear no resemblence to what happens to me at all. I tried the workaround just
posted and  got precisely the same results... I get prompted over and over and
over and over and over and over and over for my password (until I give up). I
have to repeat that I *know* my password (use it everyday with Pegasus mail). I
don't think it's got much to do with whether or not Mozilla remembers my
password correctly or not. But, as I said, I'll wait to see what the future brings.

Comment 63

[Not interested in Mozilla any more]

Jim
Your problem sounds like a completely different issue to me, unrelated to this
one. Why don't you post it as a new bug, rather than trying to reopen this one
that is apparently fixed. It would be usefull if you said what SMTP server you
where using. Just a thougth does you SMTP server need a password to send mail,
most don't. Try turning of the SSL in the mail and news settings dialog box for
your outgoing SMTP server. If that dosn't work start a new bug.
HTH
Ian

Comment 64

[Jim Coleman]

After reading Ian's note, I took another look through the SMTP client settings.
SSL was already set to "when possible" so I left that alone. The "Use Name and
Password" was checked, however. I removed the checkmark, shutdown and restarted
Mozilla and am again able to send mail. Thanks to all who hung in there with me
and to Ian especially. I'm very grateful.

Comment 65

[Matthias Versen [:Matti]]

*** Bug 150531 has been marked as a duplicate of this bug. ***

Comment 66

[Sheela Ravindran]

*** Bug 152559 has been marked as a duplicate of this bug. ***

Comment 67

[Karen Huang]

After confirmed with Navin & Cavin.
Verified fix along with bug 94775 and today's verification on all the platforms
as following:
Win 06-20-08-1.0
Linux 06-20-06-1.0
Mac 06-20-05-1.0 
Marking as verified and changing keywords to "verified 1.0.1"

Comment 68

[Navin Gupta]

*** Bug 156635 has been marked as a duplicate of this bug. ***

Comment 69

[Matthias Versen [:Matti]]

*** Bug 157916 has been marked as a duplicate of this bug. ***

Comment 70

[R.K.Aa.]

*** Bug 161345 has been marked as a duplicate of this bug. ***

Comment 71

[Sheela Ravindran]

*** Bug 161902 has been marked as a duplicate of this bug. ***

Comment 72

[Sheela Ravindran]

*** Bug 166623 has been marked as a duplicate of this bug. ***

Comment 73

[Sheela Ravindran]

*** Bug 131587 has been marked as a duplicate of this bug. ***

Comment 74

[Ram Rao]

This bug seems to have reappeared in Mozilla V1.2.1.  I have entered a new
report as bug# 190806

Comment 75

[Daniel Veditz [:dveditz]]

*** Bug 195844 has been marked as a duplicate of this bug. ***

Comment 76

[Rob Janssen]

As we still have this problem with Mozilla 1.7.13 and Thunderbird 1.0.4 I did some more research.

It seems that the fix in comment #12 does not fix it in all possible cases.

What I worked out so far using Mozilla 1.7.13:
When the mail account has "check for new messages at startup" disabled on the server settings page, the fix works ok.  After opening mail and selecting the inbox, first the message about failed login appears, with an OK box, and when that is clicked a new password entry box appears where the correct password can be typed and it can be stored.  OK.

HOWEVER: when "check for new messages at startup" is enabled, the above does NOT happen!  The program attempts to open the inbox automatically, and one gets two login failed dialogs which can be OK'ed away, but NO password box.  Any further action on the mail account causes another login failed but still no possibility to enter the password.
Maybe the "check for new messages at startup" causes the start of the services to be called too early, and they cannot be successfully started.

The only available workaround still is to remove the password using the password manager, and try again.   Unfortunately the password manager has moved even further away from the user's view in Thunderbird, so it is even more difficult for our helpdesk to explain to people how to do this over the phone.

Comment 77

[David :Bienvenu]

please try a trunk or 2.0 nightly TB or Seamonkey build - I believe this is fixed in those builds.