Closed Bug 1219264 Opened 7 years ago Closed 7 years ago

[Messages][NG] Move ActivityShim to shim host iframe

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

Attachments

(1 file)

Currently ActivityShim is the only bridge service wrapper that resides in the main window context, and the only reason why we load full bridge.js library in the main window.

But now we have nested shim iframe where we can put all our shims as well as this one. However we have to access parent window to workaround bug 818000.
Comment on attachment 8680112 [details] [review]
[gaia] azasypkin:bug-1219264-activity-shim-to-iframe > mozilla-b2g:master

Hey Steve,

How does it look?

It should allow us to use only lib/bridge/client.js in the main window in bug 1218091.

Thanks!
Attachment #8680112 - Flags: review?(schung)
So as we discussed we're delaying this one for a later time, I've remeasured memory again and confirm that there's no perf improvement at all with this patch, it only makes activity shim/client more organized.

Still would be great to have your review once you have some time, but there is no hurry at all :)
Since PR for bug 1218091 is landed, I've rebased this PR on master + removed bridge.js/bridge.min.js as you've suggested.
No longer blocks: 1218091
Comment on attachment 8680112 [details] [review]
[gaia] azasypkin:bug-1219264-activity-shim-to-iframe > mozilla-b2g:master

Looks good! For the direct communication between iframe and window, I think we might need to file a bug for it(if it should happen) since we have several places that need this changes.
Attachment #8680112 - Flags: review?(schung) → review+
See Also: → 1223363
(In reply to Steve Chung [:steveck] from comment #5)
> Comment on attachment 8680112 [details] [review]
> [gaia] azasypkin:bug-1219264-activity-shim-to-iframe > mozilla-b2g:master
> 
> Looks good! For the direct communication between iframe and window, I think
> we might need to file a bug for it(if it should happen) since we have
> several places that need this changes.

Thanks for review! Filed bug 1223363 to investigate possibility of migration to window/iframe endpoint.

Treeherder is green, landed: https://github.com/mozilla-b2g/gaia/commit/2469862c035b76b995cdb3a26737270c65327a41
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.