Closed
Bug 1219322
Opened 9 years ago
Closed 9 years ago
Document payload.info.flashVersion and payload.info.addons
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: Dexter, Assigned: Dexter)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client])
Attachments
(1 file, 1 obsolete file)
1.44 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
v4 ping payloads contain |payload.info.flashVersion| and |payload.info.addons|, but are not documented. Those fields are going to be removed when bug 1201837 lands, but still it's worth documenting them to prevent confusion: the environment data should be preferred over flashVersion & addons.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8680103 -
Flags: review?(gfritzsche)
Comment 2•9 years ago
|
||
Comment on attachment 8680103 [details] [diff] [review] bug1219322.patch Review of attachment 8680103 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/docs/main-ping.rst @@ +42,5 @@ > sessionLength: <number>, // the session length until now in seconds, monotonic > subsessionLength: <number>, // the subsession length in seconds, monotonic > + > + flashVersion: <string>, // to be removed, use ``environment.addons.activePlugins`` > + addons: <string>, // to be removed, use ``environment.addons`` I would say "obsolete" instead.
Attachment #8680103 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8680103 -
Attachment is obsolete: true
Attachment #8680105 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b836b8feea9ee7b53475dd122ff388aa6fcd37f7 Bug 1219322 - Document payload.info.flashVersion and payload.info.addons. r=gfritzsche
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b836b8feea9e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 6•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b836b8feea9e
status-b2g-v2.5:
--- → fixed
Comment 7•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•