Closed Bug 1219368 Opened 5 years ago Closed 5 years ago

Can't increment build when adding new modules

Categories

(DevTools :: General, defect)

43 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jsantell, Assigned: jryans)

References

Details

(Keywords: regression)

Attachments

(1 file)

When adding a module to moz.build, a `./mach build devtools/client/TOOL` does not build the module, resulting in things like:

Error: Module `resource://devtools/client/memory/components/frame.js` is not found at resource://devtools/client/memory/components/frame.js

It requires a top level `./mach build` to handle this. Seems similar to bug 1219077, not intuitive that this is needed when adding modules.
Flags: needinfo?(jryans)
I'll take a look.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Flags: needinfo?(jryans)
Looks like this is a regression from our move to resource://devtools in bug 1203159.  By using switching to FINAL_TARGET_FILES, we lost per-directory build dependencies.
Blocks: 1203159
No longer blocks: dt-loader
Keywords: regression
In bug 1203159, we changed DevTools to package all resources as a flattened
add-on via FINAL_TARGET_FILES.  However, this build variable did not emit
per-directory dependency data, so we lost the ability to build only one targeted
directory.  By changing FINAL_TARGET_FILES to emit similar info to other build
variables, we get the dependency tracking back.

Still needs tests, but does this seem reasonable?
Attachment #8680328 - Flags: feedback?(mh+mozilla)
Comment on attachment 8680328 [details] [diff] [review]
final-target-deps

Review of attachment 8680328 [details] [diff] [review]:
-----------------------------------------------------------------

This would be a clear regression. Please just stop using `mach build foo/bar` and expect things to keep working. Use `mach build faster`.
Attachment #8680328 - Flags: feedback?(mh+mozilla) → feedback-
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
(In reply to Mike Hommey [:glandium] from comment #4)
> Comment on attachment 8680328 [details] [diff] [review]
> final-target-deps
> 
> Review of attachment 8680328 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This would be a clear regression. Please just stop using `mach build
> foo/bar` and expect things to keep working. Use `mach build faster`.

What about directories that have both cpp and js changes, eg devtools/shared/heapsnapshot?
Flags: needinfo?(mh+mozilla)
`mach build faster` then `mach build binaries` ; or `mach build faster binaries`
Flags: needinfo?(mh+mozilla)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.