1219368 - Can't increment build when adding new modules

Status: RESOLVED WONTFIX

(DevTools :: General, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

When adding a module to moz.build, a `./mach build devtools/client/TOOL` does not build the module, resulting in things like:

Error: Module `resource://devtools/client/memory/components/frame.js` is not found at resource://devtools/client/memory/components/frame.js

It requires a top level `./mach build` to handle this. Seems similar to bug 1219077, not intuitive that this is needed when adding modules.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I'll take a look.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Looks like this is a regression from our move to resource://devtools in bug 1203159.  By using switching to FINAL_TARGET_FILES, we lost per-directory build dependencies.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: final-target-deps

In bug 1203159, we changed DevTools to package all resources as a flattened
add-on via FINAL_TARGET_FILES.  However, this build variable did not emit
per-directory dependency data, so we lost the ability to build only one targeted
directory.  By changing FINAL_TARGET_FILES to emit similar info to other build
variables, we get the dependency tracking back.

Still needs tests, but does this seem reasonable?

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8680328 [details] [diff] [review]
final-target-deps

Review of attachment 8680328 [details] [diff] [review]:
-----------------------------------------------------------------

This would be a clear regression. Please just stop using `mach build foo/bar` and expect things to keep working. Use `mach build faster`.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Mike Hommey [:glandium] from comment #4)
> Comment on attachment 8680328 [details] [diff] [review]
> final-target-deps
> 
> Review of attachment 8680328 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This would be a clear regression. Please just stop using `mach build
> foo/bar` and expect things to keep working. Use `mach build faster`.

What about directories that have both cpp and js changes, eg devtools/shared/heapsnapshot?

Comment 6

[Mike Hommey [:glandium]]

`mach build faster` then `mach build binaries` ; or `mach build faster binaries`