1219392 - Capitalize mozilla::unused to avoid conflicts

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Biru [:poiru]]

Attachment: Capitalize mozilla::unused to avoid conflicts

The tree has a bunch of identifiers named `unused` that conflict with `mozilla::unused`. The easiest way out is to switch to `mozilla::Unused`.

Note that the patch intentionally has no context.

Comment 1

[Jeff Walden [:Waldo]]

Ongoing shout-out to fix compilers that don't like cast-to-void as a way to use return values!  (I am not suggesting or requiring you do this, just that mozilla::unused is stupid practice IMO.  :-) )

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Birunthan Mohanathas [:poiru] from comment #0)
> The tree has a bunch of identifiers named `unused` that conflict with
> `mozilla::unused`. The easiest way out is to switch to `mozilla::Unused`.

My impression was that this was only an issue with the Chromium-imported ipc code.  Where are the other problems?

Comment 3

[Andrew McCreight [:mccr8]]

I actually did write a patch not to long ago to eliminate the places people call things 'unused', though Nathan suggested another work around. It wasn't too bad. But of course, people are going to keep adding them.

Comment 4

[Biru [:poiru]]

(In reply to Nathan Froyd [:froydnj] from comment #2)
> (In reply to Birunthan Mohanathas [:poiru] from comment #0)
> > The tree has a bunch of identifiers named `unused` that conflict with
> > `mozilla::unused`. The easiest way out is to switch to `mozilla::Unused`.
> 
> My impression was that this was only an issue with the Chromium-imported ipc
> code.  Where are the other problems?

See https://dxr.mozilla.org/mozilla-central/search?q=ext%3Acpp+regexp%3A\bunused[^\.][^%3C]\b&redirect=false&case=true

Many of those are comments, but there are still a few actual hits.

Comment 5

[Biru [:poiru]]

(In reply to Birunthan Mohanathas [:poiru] from comment #4)
> See
> https://dxr.mozilla.org/mozilla-central/
> search?q=ext%3Acpp+regexp%3A\bunused[^\.][^%3C]\b&redirect=false&case=true
> 
> Many of those are comments, but there are still a few actual hits.

I forgot that DXR is smart. This is a far better search: https://dxr.mozilla.org/mozilla-central/search?q=ext%3Acpp+id%3Aunused&redirect=true&case=true

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8680148 [details] [diff] [review]
Capitalize mozilla::unused to avoid conflicts

Review of attachment 8680148 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe we should call it "bitbucket" instead. ;)

But yeah, the second DXR query and the since of this patch are a little more convincing.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec70e0c6997

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7ec70e0c6997

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7ec70e0c6997