Closed Bug 1219444 Opened 9 years ago Closed 3 years ago

Add telemetry for new "Open in Firefox" button in share overlay

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mcomella, Assigned: an0nym0usdroid42)

References

Details

Attachments

(1 file)

bug 1155860 implemented this button and we should add telemetry.

Finkle gave suggestions in bug 1155860 comment 65:
(In reply to Anthony Lam (:antlam) from comment #64)
> It'd be nice to be able to get some telemetry on this item as well.

We already do other telemetry here, for example:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/overlays/ui/ShareDialog.java#403

Sounds like we'd put something here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/overlays/ui/ShareDialog.java#416

I don't think we'd use Event.LOAD_URL here because we'd already use Event.LOAD_URL in Fennec. We could use Event.LAUNCH for this.
Hi Mike, I have attached the diff as sort of trial for now. Didn't have much idea about telemetry, but going by the comment, is this what is required ? Let me know I'll then submit a patch for review
Flags: needinfo?(michael.l.comella)
Comment on attachment 8681583 [details] [diff] [review]
bug1219444_t1.diff

Review of attachment 8681583 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/overlays/ui/ShareDialog.java
@@ +407,5 @@
>      }
>  
>      public void launchBrowser() {
>          try {
> +            Telemetry.sendUIEvent(TelemetryContract.Event.LAUNCH, TelemetryContract.Method.SHARE_OVERLAY, "open_browser");

I see we already use LAUNCH elsewhere and it looks like we use "browser" for the extra:
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/SearchWidget.java?rev=dff7128718c4#74

Otherwise, looks good! I'm going to give the final review to Finkle though because he looks at these more than I do.
Attachment #8681583 - Flags: review?(mark.finkle)
Flags: needinfo?(michael.l.comella)
Comment on attachment 8681583 [details] [diff] [review]
bug1219444_t1.diff

>diff --git a/mobile/android/base/overlays/ui/ShareDialog.java b/mobile/android/base/overlays/ui/ShareDialog.java

>+            Telemetry.sendUIEvent(TelemetryContract.Event.LAUNCH, TelemetryContract.Method.SHARE_OVERLAY, "open_browser");

I agree with Mike. Let's change this to "browser" and then we'll land it.
Attachment #8681583 - Flags: review?(mark.finkle) → review+
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: