1219576 - [TV Browser] Failed to remove the bookmark

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)

Description

[Cynthia Tang [:cynthiatang]]

============== Gaia Information ==============
commit ed9f29f7da11370b7c9c4a9cf3d11139537539df
Merge: 70faabf 5df0f5a
Author: tamarahills <[e-mail]>
Date:   Tue Oct 27 21:58:46 2015 -0400

STR: 
 1. Launch Browser
 2. Go to "cnn.com"
 3. Press the star icon to bookmark the current page 
 4. Press the star icon again

Expected Result
 - The current page can be removed from Bookmarks

Actual Result:
 - The current page cannot be removed from Bookmarks

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1219576_failed_to_remove_bookmark > mozilla-b2g:master

Comment 2

[Dan Huang[:danhuang]]

Comment on attachment 8680514 [details] [review]
[gaia] danhuang1202:1219576_failed_to_remove_bookmark > mozilla-b2g:master

Please help me to review. This patch fix the issue of deleting bookmark failed. Thanks.

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8680514 [details] [review]
[gaia] danhuang1202:1219576_failed_to_remove_bookmark > mozilla-b2g:master

Hey Dan,

LGTM! Thanks for this effort. :)
Please modify the comment message to this:
Bug 1219576 - [TV Browser] Fix bookmark removing issue. r=seanlee

Please notice that commit message should describe what the patch did rather than the bug description or bug subject.

Comment 4

[Dan Huang[:danhuang]]

Thanks for the review and the advice of commit message. I updated the commit message as you mentioned.(In reply to Sean Lee [:seanlee] from comment #3)
> Comment on attachment 8680514 [details] [review]
> [gaia] danhuang1202:1219576_failed_to_remove_bookmark > mozilla-b2g:master
> 
> Hey Dan,
> 
> LGTM! Thanks for this effort. :)
> Please modify the comment message to this:
> Bug 1219576 - [TV Browser] Fix bookmark removing issue. r=seanlee
> 
> Please notice that commit message should describe what the patch did rather
> than the bug description or bug subject.

Comment 5

[Dan Huang[:danhuang]]

Merge in master:
https://github.com/mozilla-b2g/gaia/commit/5ff8beff1baf2a674aa55b8de77533b367e36713