Closed Bug 1219609 Opened 9 years ago Closed 9 years ago

Change header of bookmarks view from 'Bookmark' to 'Bookmarks'

Categories

(Firefox OS Graveyard :: Sync, defect)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.5 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed

People

(Reporter: mbdejong, Assigned: danhuang)

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

[gaia] danhuang1202:1219609_change_header_from_bookmark_to_bookamrkd > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
mpotharaju
: approval-gaia-v2.5+
Details | Review 
      No description provided.
Flags: needinfo?(yliao)
In the TV browser, I mean.
Dan could you help on this one? Thanks!
Flags: needinfo?(yliao) → needinfo?(dhuang)
Yes! I will take this!
Assignee: nobody → dhuang
Flags: needinfo?(dhuang)
Comment on attachment 8681780 [details] [review]
[gaia] danhuang1202:1219609_change_header_from_bookmark_to_bookamrkd > mozilla-b2g:master

Hi Yi-Fan, please help me to review. This patch simply change i10n string from LT_NET_BOOKMARK to bookmarks. Thanks.
Attachment #8681780 - Flags: review?(yliao)
Comment on attachment 8681780 [details] [review]
[gaia] danhuang1202:1219609_change_header_from_bookmark_to_bookamrkd > mozilla-b2g:master

Please request approval for 2.5, thanks!
Attachment #8681780 - Flags: review?(yliao) → review+
Thanks for the review.
Comment on attachment 8681780 [details] [review]
[gaia] danhuang1202:1219609_change_header_from_bookmark_to_bookamrkd > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1194108
[User impact] if declined: May let user think there only show one bookmark record at a time in the bookmark list.
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f3b85ce18d5bb51cfba7632a995187c7ea66d6a9
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]: Yes
Attachment #8681780 - Flags: approval-gaia-v2.5?
Merge in master: 
https://github.com/mozilla-b2g/gaia/commit/f46def95140d3c0e027ddabc69891ad4b4d2c4ee
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
Comment on attachment 8681780 [details] [review]
[gaia] danhuang1202:1219609_change_header_from_bookmark_to_bookamrkd > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks
Attachment #8681780 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: