Closed Bug 1219618 Opened 9 years ago Closed 9 years ago

(Gaia RTL 2.5) CSS refactoring System followup: Notifications.

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-master fixed)

RESOLVED FIXED
Tracking Status
b2g-master --- fixed

People

(Reporter: autra, Assigned: autra)

References

Details

Attachments

(1 file)

This bug is for the refactoring of notifications for RTL.

We need to:
- correctly honour the `dir` parameter which the notification was created with
- correctly align the UI elements according to the current system language.
- mirror the disappearing transition when clicking on "clear all"
Blocks: 1212329, 1181944
Assignee: nobody → augustin.trancart
Status: NEW → ASSIGNED
Comment on attachment 8680562 [details] [review]
[gaia] Phoxygen:bug1219618-system_notification_followup > mozilla-b2g:master

Hey Etienne,

So that's the first part of bug 1212329, concerning notifications. Please r?
Attachment #8680562 - Flags: review?(etienne)
Comment on attachment 8680562 [details] [review]
[gaia] Phoxygen:bug1219618-system_notification_followup > mozilla-b2g:master

Thanks! Much easier to review :)
Please rebase to get a green try build before merging, but this should be good to go!
Attachment #8680562 - Flags: review?(etienne) → review+
\o/ Yay \o/
A bit difficult to get some green today, but I have it at last :-)
Keywords: checkin-needed
Merged to master: https://github.com/mozilla-b2g/gaia/commit/a91e60207d465db1525a0db74e118b12109a6858
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8680562 [details] [review]
[gaia] Phoxygen:bug1219618-system_notification_followup > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): None
[User impact] if declined: Poor RTL support
[Testing completed]: on flame 
[Risk to taking this patch] (and alternatives if risky): medium because it touches a shared part. Also followups (bug 1220563 and 1212329) should be uplifted too (after this one).
[String changes made]: None
Attachment #8680562 - Flags: approval-gaia-v2.5?
Comment on attachment 8680562 [details] [review]
[gaia] Phoxygen:bug1219618-system_notification_followup > mozilla-b2g:master

Already in 2.5.
Attachment #8680562 - Flags: approval-gaia-v2.5?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: