1219627 - Implement *test_browser_play_video.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/browser/test_browser_play_video.py

Comment 1

[Alberto Pastor [:albertopq]]

Martijn, do you know if we can execute things like [1] in our JS marionette client?
I tried with the same .executeScript method and doesn't seem to work.
Do you know who can help with this?

Thanks!

[1] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/search/regions/html5_player.py#L73

Comment 2

[Martijn Wargers (dead)]

Weird that it doesn't work. It can be tricky, because of native anonymous content and shadow dom here. I could take a look at it next week (currently on vacation).

Comment 3

[Martijn Wargers (dead)]

Alberto, could you perhaps attach a pull request/patch of what you have thus far, then I'll try and see if I can get it working.

Comment 4

[Alberto Pastor [:albertopq]]

This is what I got so far -> https://github.com/albertopq/gaia/tree/1219627-video-test

Is just trying to execute a simple method for getting the location of one of the shadow dom elements, and wanted to make sure this is supported in the js client before spending too much time on it.

Let me know if I can help with something!
Thanks!

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1219627-video-test > mozilla-b2g:master

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

I've rebased this commit and ran the CI tests [1], everything is looking green. I'm going to do the review myself and merge. If Martijn has further comments about this test let's fix this in a followup.

1.) https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=332d1f6024386b9080d6b1458f1c90ae18214c30

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/68e9b3863c6cafab6621ace31e99ef3fd328c8ed

Comment 8

[Martijn Wargers (dead)]

I'm sorry, I don't understand MarionetteJS enough to give meaningful comments to the code. It all seems weird to me in general.