1219628 - Implement *test_browser_save_image.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/browser/test_browser_save_image.py

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1219628-test-save-image > mozilla-b2g:master

Comment 2

[Alberto Pastor [:albertopq]]

I've tried everything, but the test passes just fine locally and crashes in treeherder with this error:

TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_context_menu_test.js | Browser Context Menu "after each" hook for "save image"
Error: Error polling recv() socket!
    at Error (native)
    at TcpSync._readResponse (node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:160:30)
    at TcpSync.sendRaw (node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:226:18)
    at TcpSync.sendMessage (node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:209:15)
    at TcpSync.send (node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:190:17)
    at Object.send (node_modules/marionette-client/lib/marionette/client.js:492:34)
    at Object.Client._sendCommand (node_modules/marionette-client/lib/marionette/client.js:553:21)
    at Object.closeDriver (node_modules/marionette-client/lib/marionette/client.js:848:14)
    at Object.executeHook (node_modules/marionette-client/lib/marionette/client.js:382:20)
    at Object.Client.runHook (node_modules/marionette-client/lib/marionette/client.js:400:7)
    at Object.destroySession [as deleteSession] (node_modules/marionette-client/lib/marionette/client.js:859:12)
    at node_modules/marionette-js-runner/node_modules/promise/lib/node-extensions.js:25:20
    at doResolve (node_modules/marionette-js-runner/node_modules/promise/lib/core.js:91:5)
    at new Promise (node_modules/marionette-js-runner/node_modules/promise/lib/core.js:71:3)
    at node_modules/marionette-js-runner/node_modules/promise/lib/node-extensions.js:17:12
    at Context.<anonymous> (node_modules/marionette-js-runner/lib/runtime/hostmanager.js:147:14)
Exit code 2

Gareth, any idea?

Comment 3

[Alberto Pastor [:albertopq]]

Comment on attachment 8698897 [details] [review]
[gaia] albertopq:1219628-test-save-image > mozilla-b2g:master

Switching review to Michael, as Johan is in PTO.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8698897 [details] [review]
[gaia] albertopq:1219628-test-save-image > mozilla-b2g:master

Looking good, thanks! I left a couple of nits on github. I'm going to go ahead and merge this for now, but let's file a follow up when you get back to enable the `getSdCardFilesMatching` check once bug 1091622 is fixed.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/d17f0bc09e32184f071463560a06a6c3a5b7e50f