Closed
Bug 1219636
Opened 9 years ago
Closed 8 years ago
Implement *test_import_contacts_from_sdcard.py* as an integration test in JavaScript
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(feature-b2g:2.6+)
RESOLVED
FIXED
| feature-b2g | 2.6+ |
People
(Reporter: whsu, Assigned: arcturus)
References
Details
(Whiteboard: [gip-to-gij])
Attachments
(1 file)
|
Reporter | |
Updated•9 years ago
|
Component: Gaia::UI Tests → Gaia::Contacts
|
||
Updated•9 years ago
|
feature-b2g: --- → 2.6+
|
Assignee | |
Comment 1•9 years ago
|
||
Hei Johan, how are we planning to deal with hardware requirements here?
Flags: needinfo?(jlorenzo)
|
||
Comment 2•9 years ago
|
||
I checked: Mulet supports SD cards, if you put files under $profile/storage/default. MarionetteJS enables to push files to the device[1]. You can see an example here[2]. [1] https://github.com/mozilla-b2g/gaia/blob/master/tests/jsmarionette/plugins/marionette-file-manager/README.md [2] https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/test/marionette/edit_image_test.js#L27
Flags: needinfo?(jlorenzo)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → francisco
Status: NEW → ASSIGNED
|
||
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8699035 [details] [review] [gaia] arcturus:bug-1219636 > mozilla-b2g:master Hei Johan, r? Thanks!
Attachment #8699035 -
Flags: review?(jlorenzo)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8699035 [details] [review] [gaia] arcturus:bug-1219636 > mozilla-b2g:master Thanks for the test. I prefer not r+'ing yet, due to the amount of small changes. There is one change big I proposed in there (implementing the Page Object pattern) which should help in the maintainability of the tests. Based on the time frame, I'm fine if we keep the test outline as is, in this patch.
Attachment #8699035 -
Flags: review?(jlorenzo)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks for the feedback, I added some comments, to keep some stuff, but will try to implement most of the suggestions.
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8699035 [details] [review] [gaia] arcturus:bug-1219636 > mozilla-b2g:master Suggestions implemented, johan can you r?
Attachment #8699035 -
Flags: review?(jlorenzo)
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8699035 [details] [review] [gaia] arcturus:bug-1219636 > mozilla-b2g:master The small changes look good. Thanks!
Attachment #8699035 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 9•8 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/4a5fc6dabf8d92a57b4bd69942b33aebdb5bb9d4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•