1219653 - Implement *test_dialer_add_contact.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_dialer_add_contact.py
test_dialer_add_contact.py

Comment 1

[Isabel Rios[:isabel_rios]]

Attachment: PR

Comment 2

[Isabel Rios[:isabel_rios]]

Comment on attachment 8710931 [details] [review]
PR

Hey Johan, would you mind to do a first review of this new test case in js?
Thank you!

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8710931 [details] [review]
PR

That's a good start! It looks good overall. There are some small changes to make here and there, though. I left more details in the PR.

Comment 4

[Isabel Rios[:isabel_rios]]

Hi Johan! Thanks for the review! I did the suggested modifications, everything except for two comments that I do not know how to resolve, they are commented in the PR.
Thank you again for your help.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8710931 [details] [review]
PR

We're getting closer!

Once the input data is created in the test and the keypad view doesn't return itself, we'll be good to go, from my point of view.

Comment 6

[Isabel Rios[:isabel_rios]]

Thanks Johan for your help and review. I made the changes requested. Hope it is ok now.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8710931 [details] [review]
PR

Looks great! Thanks!

Comment 8

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8710931 [details] [review]
PR

Looks good to me, I've just left some nits about code formatting but besides those this is ready to land.

Comment 9

[Isabel Rios[:isabel_rios]]

Thank you for the reviews!
There were three failures: Gij11 and Gij18, failing in tha last commit also, and Gij31 that seemed to be an intermitent as I run it again several times getting it green.

Merged in master: https://github.com/mozilla-b2g/gaia/commit/10cbd5cdf8f3bf986af17b88d3437bbf142bf411