Implement *test_ftu_status_bar.py* as an integration test in JavaScript

RESOLVED FIXED in Firefox OS master

Status

Firefox OS
Gaia::First Time Experience
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: whsu, Assigned: sfoster)

Tracking

(Blocks: 1 bug)

unspecified
2.6 S1 - 11/20
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.6+, b2g-master fixed)

Details

(Whiteboard: [gip-to-gij][systemsfe])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_status_bar.py
(Reporter)

Updated

2 years ago
Component: Gaia::UI Tests → Gaia::First Time Experience
feature-b2g: --- → 2.6+
For triage. Do we need anything to do here?
Flags: needinfo?(sfoster)
(Assignee)

Comment 2

2 years ago
We have apps/ftu/test/marionette/statusbar_test.js, but the UI test also has asserts for the statusbar being displayed during the tutorial. If we add those to statusbar_test.js we'll be done.
Flags: needinfo?(sfoster)

Comment 3

2 years ago
Created attachment 8685103 [details] [review]
[gaia] sfoster:ftu-statusbar-gij-bug-1219655 > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Assignee: nobody → sfoster
Target Milestone: --- → 2.6 S1 - 11/20
(Assignee)

Comment 4

2 years ago
Comment on attachment 8685103 [details] [review]
[gaia] sfoster:ftu-statusbar-gij-bug-1219655 > mozilla-b2g:master

This looks pretty green, asking for review as I moved/changed quite a bit
Attachment #8685103 - Flags: review?(mhenretty)
Comment on attachment 8685103 [details] [review]
[gaia] sfoster:ftu-statusbar-gij-bug-1219655 > mozilla-b2g:master

Glad to see Gij improving. r=me
Attachment #8685103 - Flags: review?(mhenretty) → review+
(Assignee)

Comment 6

2 years ago
Merged to master: https://github.com/mozilla-b2g/gaia/commit/22f8023b112dfae83531b0a075ab9eb9a5444dfa
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Whiteboard: [gip-to-gij] → [gip-to-gij][systemsfe]
The python checks the status bar is present during the FTU[1] and during the tutorial. I'm not sure the assertions are done for the FTU part in statusbar_test.js. Sam, would you mind pointing the FTU part out? Thanks!

[1] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_status_bar.py#L27
Flags: needinfo?(sfoster)
(Assignee)

Comment 8

2 years ago
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #7)
> The python checks the status bar is present during the FTU[1] and during the
> tutorial. I'm not sure the assertions are done for the FTU part in
> statusbar_test.js. Sam, would you mind pointing the FTU part out? Thanks!

Johan, the patch adds a check for the status bar at each step in the tutorial[1], but you're right that it doesn't verify it is visible at each step in the first part of the FTU. I've re-opened and I'll get a follow-up patch together.


1. https://github.com/mozilla-b2g/gaia/commit/22f8023b112dfae83531b0a075ab9eb9a5444dfa#diff-59984c8f09d0fed34293efb8a493bfc2R19
Status: RESOLVED → REOPENED
Flags: needinfo?(sfoster)
Resolution: FIXED → ---
(Assignee)

Comment 9

2 years ago
Created attachment 8688056 [details] [review]
PR: Check statusbar is displayed at each FTU step

Adds a check to ensure statusbar is still displayed during each step of the FTU, to get parity with test_ftu_status_bar.py
Attachment #8688056 - Flags: review?(mhenretty)
Comment on attachment 8688056 [details] [review]
PR: Check statusbar is displayed at each FTU step

Excellent, thanks.
Attachment #8688056 - Flags: review?(mhenretty) → review+
(Assignee)

Comment 11

2 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/2893aea9f51007e8ad424a7c5a482418959f0677
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
status-b2g-master: --- → fixed
Resolution: --- → FIXED
Blocks: 1228972
You need to log in before you can comment on or make changes to this bug.