1219657 - Implement *test_gallery_delete_multiple_images.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_delete_multiple_images.py

Comment 1

[Hema Koka [:hema]]

Delete multiple images is not covered yet in the JS tests. Please check and address it.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] punamdahiya:Bug1219657 > mozilla-b2g:master

Comment 3

[Punam Dahiya [:pdahiya]]

Comment on attachment 8687415 [details] [review]
[gaia] punamdahiya:Bug1219657 > mozilla-b2g:master

Hi David

Please review attached patch with Gij tests for gallery app delete multiple images flow. This also covers Gij test for delete multiple images cancel flow (Bug 1219656). Thanks!

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8687415 [details] [review]
[gaia] punamdahiya:Bug1219657 > mozilla-b2g:master

I didn't run the test, and I left a few comments on github, but overall this looks good to me.  I think it would be more interesting to do the single image delete test with multiple thumbnails rather than just one, so I think you could combine the single and multiple delete cases into a single suite. But if you just want to get this gip test ported, you've done that and can land it this way, if you want.

It looks like we don't have any test for the single image delete from the bottom toolbar, and should probably add that at some point, but that doesn't have to be part of this.

Comment 5

[Punam Dahiya [:pdahiya]]

Thanks David for review, patch landed on master

https://github.com/mozilla-b2g/gaia/commit/9ce8dc0286f781cbffa83383fd8e35221829e82b