Closed
Bug 1219662
Opened 9 years ago
Closed 8 years ago
Implement *test_gallery_view.py* as an integration test in JavaScript
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(feature-b2g:2.6+)
RESOLVED
FIXED
feature-b2g | 2.6+ |
People
(Reporter: whsu, Assigned: pdahiya)
References
Details
(Whiteboard: [gip-to-gij])
Attachments
(1 file)
Reporter | ||
Updated•9 years ago
|
Component: Gaia::UI Tests → Gaia::Gallery
Updated•9 years ago
|
feature-b2g: --- → 2.6+
Assignee | ||
Comment 1•9 years ago
|
||
Python test in #comment 0 is a fullscreen view test case that tests gallery app changes orientation successfully in fullscreen view. This test case should be implemented in JS. Thanks!
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → pdahiya
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8698180 [details] [review] [gaia] punamdahiya:Bug1219662 > mozilla-b2g:master Hi David Attaching patch having Gij test for gallery app fullScreenView change orientation. Please review. Thanks!
Attachment #8698180 -
Flags: review?(dflanagan)
Comment 4•8 years ago
|
||
Comment on attachment 8698180 [details] [review] [gaia] punamdahiya:Bug1219662 > mozilla-b2g:master I left a couple of comments on github. I know the python test does not test this, but it would be nice (in some other later bug) to test that the image itself (or the MediaFrame that holds it) is being resized when the orientation changes.
Attachment #8698180 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to David Flanagan [:djf] from comment #4) > Comment on attachment 8698180 [details] [review] > [gaia] punamdahiya:Bug1219662 > mozilla-b2g:master > > I left a couple of comments on github. > Updated patch with feedback. > I know the python test does not test this, but it would be nice (in some > other later bug) to test that the image itself (or the MediaFrame that holds > it) is being resized when the orientation changes. I agree, will create a bug to test MediaFrame getting resized on Orientation change a part of improve gallery App test coverage.
Assignee | ||
Comment 6•8 years ago
|
||
Patch landed on master https://github.com/mozilla-b2g/gaia/commit/285dc78d306f366fd2a915759acb1939156d1660
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•