Closed Bug 1219723 Opened 5 years ago Closed 5 years ago

Package gcli files with the same layout than source tree

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set

Tracking

(firefox45 fixed, b2g-v2.5 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file, 2 obsolete files)

Per bug 1217472 comment 1, we should be packaging gcli in firefox jar files with the same layout it has in the source tree.
That does not prevent having a shortcut that allows to load gcli via:
  require("gcli/system")
Attached patch patch v1 (obsolete) — Splinter Review
Attached patch patch v2 (obsolete) — Splinter Review
This patch also cleans up Loader.jsm from unecessary devtools/client > resource://devtools/client mapping.
I removed gcli.jsm as it doesn't seem to be used anywhere?

With this patch we can then map gcli to resource://devtools/shared/gcli/source/lib/
And resource://devtools now can be mapping to mozilla-central/devtools/,
at least, regarding gcli...
Attachment #8680602 - Flags: review?(jryans)
Attachment #8680585 - Attachment is obsolete: true
Comment on attachment 8680602 [details] [diff] [review]
patch v2

Review of attachment 8680602 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/shared/gcli/gcli.jsm
@@ -1,1 @@
> -/*

I think this was kept for add-ons, but then we moved it, so they would be broken now anyway.  I think it's fine to remove, but let's check with :jwalker.
Attachment #8680602 - Flags: review?(jryans) → review+
Comment on attachment 8680602 [details] [diff] [review]
patch v2

:jwalker, is it safe to remove gcli.jsm?  It appears unused, but I wasn't sure about the details.
Attachment #8680602 - Flags: feedback?(jwalker)
Comment on attachment 8680602 [details] [diff] [review]
patch v2

Review of attachment 8680602 [details] [diff] [review]:
-----------------------------------------------------------------

Kill it with fire.
Attachment #8680602 - Flags: feedback?(jwalker) → feedback+
Attached patch patch v3Splinter Review
Fixed the loader test, we now have only xpcshell-test mapping missing in srcdir-loader.
Attachment #8681883 - Flags: review+
Attachment #8680602 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/3db104bc7a740fe52447b92a7a77dba0a2d3197a
Bug 1219723 - Package gcli with the same layout than in the source tree. r=jryans
https://hg.mozilla.org/mozilla-central/rev/3db104bc7a74
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Assignee: nobody → poirot.alex
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.