Closed
Bug 1219740
Opened 9 years ago
Closed 9 years ago
Add back the beta tag to the panel
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox45 fixed)
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: standard8, Assigned: dcritchley)
References
Details
(Keywords: regression, Whiteboard: [web sharing])
Attachments
(3 files, 2 obsolete files)
99.88 KB,
image/png
|
Details | |
3.06 KB,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
34.85 KB,
image/png
|
sevaan
:
ui-review+
|
Details |
Somewhere in the re-arrangement of the panel for the web sharing user story, the beta tag has been lost. We need to add it back again.
Reporter | ||
Updated•9 years ago
|
Rank: 21
Reporter | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → david.critchley
Assignee | ||
Comment 2•9 years ago
|
||
Add Beta Ribbon back in
Attachment #8680966 -
Flags: review?(dmose)
Assignee | ||
Comment 3•9 years ago
|
||
Beta Ribbon added back in, attachment shows ribbon placement same as before
Attachment #8680970 -
Flags: ui-review?(sfranks)
Comment 4•9 years ago
|
||
Comment on attachment 8680970 [details] Beta Ribbon added back in Hey David, I believe this bug is about adding the beta tag to the panel. I don't believe we need it on the Link Clicker. http://people.mozilla.org/~sfranks/Hello/Firefox%20Hello%20Link%20Generator.png
Attachment #8680970 -
Flags: ui-review?(sfranks) → ui-review-
Assignee | ||
Updated•9 years ago
|
Attachment #8680966 -
Flags: review?(dmose)
Assignee | ||
Comment 5•9 years ago
|
||
Add Beta Ribbon back in
Attachment #8680966 -
Attachment is obsolete: true
Attachment #8681378 -
Flags: review?(dmose)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8680970 -
Attachment is obsolete: true
Attachment #8681379 -
Flags: ui-review?(sfranks)
Updated•9 years ago
|
Attachment #8681379 -
Flags: ui-review?(sfranks) → ui-review+
Comment 7•9 years ago
|
||
Comment on attachment 8681378 [details] [diff] [review] Attachment to Bug 1219740 - Add back the beta tag to the panel Review of attachment 8681378 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=dmose. I'll test and land in a bit.
Attachment #8681378 -
Flags: review?(dmose) → review+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0eabc4ad2bcc0dc374a43b2c765995d3d5d4447e Bug 1219740 - Add Beta Ribbon back in to Hello, r=dmose
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0eabc4ad2bcc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 10•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0eabc4ad2bcc
status-b2g-v2.5:
--- → fixed
Comment 11•9 years ago
|
||
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Updated•9 years ago
|
Iteration: --- → 44.3 - Nov 2
You need to log in
before you can comment on or make changes to this bug.
Description
•