Closed Bug 1219740 Opened 9 years ago Closed 9 years ago

Add back the beta tag to the panel

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Iteration:
44.3 - Nov 2
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: standard8, Assigned: dcritchley)

References

Details

(Keywords: regression, Whiteboard: [web sharing])

Attachments

(3 files, 2 obsolete files)

UX showing beta tag
99.88 KB, image/png
Details
Attachment to Bug 1219740 - Add back the beta tag to the panel
3.06 KB, patch
dmosedale
: review+
Details | Diff | Splinter Review
And Beta Ribbon moved to Panel
34.85 KB, image/png
sevaan
: ui-review+
Details 
Somewhere in the re-arrangement of the panel for the web sharing user story, the beta tag has been lost.

We need to add it back again.
Rank: 21
Attached image UX showing beta tag — 

    
  
Assignee: nobody → david.critchley

    
    

    
  


  
Add Beta Ribbon back in

        Attachment #8680966 -
        Flags: review?(dmose)

    
    

    
  

      
      
      
      

        Attached image
          
        Beta Ribbon added back in (obsolete)
        — 
      

    


  
Beta Ribbon added back in, attachment shows ribbon placement same as before

        Attachment #8680970 -
        Flags: ui-review?(sfranks)

    
    

    
  
Comment on attachment 8680970 [details]
Beta Ribbon added back in

Hey David,

I believe this bug is about adding the beta tag to the panel. I don't believe we need it on the Link Clicker.

http://people.mozilla.org/~sfranks/Hello/Firefox%20Hello%20Link%20Generator.png

        Attachment #8680970 -
        Flags: ui-review?(sfranks) → ui-review-

    
  

        Attachment #8680966 -
        Flags: review?(dmose)

    
    

    
  


  
Add Beta Ribbon back in

        Attachment #8680966 -
        Attachment is obsolete: true

        Attachment #8681378 -
        Flags: review?(dmose)

    
    

    
  


  

        Attachment #8680970 -
        Attachment is obsolete: true

        Attachment #8681379 -
        Flags: ui-review?(sfranks)

        Attachment #8681379 -
        Flags: ui-review?(sfranks) → ui-review+

    
    

    
  
Comment on attachment 8681378 [details] [diff] [review]
Attachment to Bug 1219740 - Add back the beta tag to the panel

Review of attachment 8681378 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=dmose.  I'll test and land in a bit.

        Attachment #8681378 -
        Flags: review?(dmose) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0eabc4ad2bcc
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox45:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

    
    

    
  
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

    
  
Iteration: --- → 44.3 - Nov 2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: