Closed
Bug 1219767
Opened 9 years ago
Closed 9 years ago
Explicitly load extensions at Bugzilla->login
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
References
Details
Attachments
(1 file)
|
480 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Currently, extensions are loaded when Bugzilla->login is called. This is not exactly intentional. Extensions are loaded by Bugzilla::Hook::process, which is called in Bugzilla::Auth::Login::Stack->new. I think it would be better to make this action explicit and documented. An alternative strategy would be to hook in @INC that causes extensions to be loaded when a Bugzilla::Extension::* namespace is loaded.
|
Assignee | |
Comment 1•9 years ago
|
||
An @INC hook is too complicated without an audit of the extension loading code. Current behavior is only applicable to dev enviroments -- all extensions are preloaded under mod_perl (and thus, bmo production).
Summary: Explicitly load extensions or provide an @INC hook that loads them → Explicitly load extensions at Bugzilla->login
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8684239 -
Flags: review?(dkl)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8684239 [details] [diff] [review] 1219767_1.patch Review of attachment 8684239 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl
Attachment #8684239 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git af46939..4c8b7b1 master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•