1219772 - Store the type of extension (legacy or webextension) in the database

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Mathieu Agopian [:magopian]]

We want to store the "type" of the extension in the database.
We already have an "addon type" field to store if it's an extension, a theme, a dictionary, a search tool... We don't want to add new type like that, because of all the mecanics that are based on those existing types. Also, a WebExtension is just a new format for extensions.

So we could add a "is_webextension" boolean field on the File model.

Comment 1

[Mathieu Agopian [:magopian]]

We also want to log/graph whenever we have a new submission:
- the addon type
- if it's a webextension or not

Comment 2

[Andy McKay]

Kev I'm thinking we want to know if a file uses WebExtensions, XUL, SDK, restartless. Anything else? Most of the things in this list might already be figureable out.

Comment 3

[Kev Needham [:kev]]

We should probably take a hard look at how we apply tags and flags, tbh, especially as Ideatown and Go Faster ramp up, and also where that information will be required (pref, manifest, elsewhere). Within Go Faster and Ideatown I can see sub-types being defined, and it'd be good to understand what the goals of new metadata points are, how they'll be used, and look at creating a model that's a little more extensible than we have now.

Comment 4

[Andy McKay]

Pushing out, we'll do this by returning data from the validator and that won't land in this iteration.

Comment 5

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/1017

We're finally doing it before we have the metadata from the validator. We'll delete this code if no more needed once we have it.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/1318090587d0097418b0e7c33b6371619846e646
Add File.is_webextension field (bug 1219772)

https://github.com/mozilla/olympia/commit/c4115621a749902913fb104a0225d54e805cb2c9
Merge pull request #1017 from magopian/1219772-store-is_webextension-on-file

Add File.is_webextension field (bug 1219772)

Comment 7

[Mathieu Agopian [:magopian]]

No STRs for this one, it's only in the database.