1219792 - Do not create Version for invalid uploads that pass auto-validation

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect, P1)

Description

[Kumar McMillan [:kumar]]

STR:
- Sign in to the developer hub and upload an unlisted add-on 
- Create an add-on that will fail validation for any reason (corrupt zip or whatever)
- Upload the new add-on version using the API (bug 1208561)
- See that the add-on failed validation
- Fix the validation errors
- Attempt to re-upload the same version

This results in a 409 conflict because "the version already exists". The API should let you make corrections without having to create a new version.

Comment 1

[Kumar McMillan [:kumar]]

With a clone of jpm, it's possible to reproduce this with:

jpm sign --api-key ... --api-secret ... --api-url-prefix http://olympia.dev/en-US/firefox/api/v3

(olympia.dev points to my local docker server)

Comment 2

[Mark Striemer [:mstriemer]]

As noted in bug 1221691 this happens because even though the file doesn't pass validation it passed auto validation and that is being treated as enough to create the Version but it should not. The fix should be outlined in this gist [1].

[1] https://gist.github.com/mstriemer/4e378aa31dfeb3a35751

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/23f8b850a4f4f5d00423f421cb2c359ec71c50c1
Don't create a Version if an add-on fails validation (bug 1219792)

Comment 4

[Kumar McMillan [:kumar]]

I just verified this as fixed on stage