xpcshell bustage from version number bump

RESOLVED FIXED in Firefox 45

Status

()

Firefox
Sync
--
blocker
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: philor, Unassigned)

Tracking

Trunk
Firefox 45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Something didn't like having the version go from 44 to 45, busting xpcshell, https://treeherder.mozilla.org/logviewer.html#?job_id=2546798&repo=mozilla-central

m-c's closed, "on a CLOSED TREE" por favor.
This is preventing us from merging the version bump around and reopening trunk trees. Any chance you can take a look? Is Sync itself still working? Could we just disable these tests for now to green things up until a fix can land?
Flags: needinfo?(markh)
Flags: needinfo?(adw)
I'm not familiar with these tests at all.  It looks like Kit recently added the lines where these tests are now failing.
Flags: needinfo?(adw) → needinfo?(kcambridge)
e.g.

http://hg.mozilla.org/mozilla-central/annotate/ac68828c5e3e/services/sync/tests/unit/test_addons_store.js#l398

http://hg.mozilla.org/mozilla-central/annotate/f4ccde68eaf7/services/fxaccounts/tests/xpcshell/test_accounts.js#l230
I'm not sure why the telemetry tests are failing. I'll have a look; if nothing else, I can back out the test changes.
Created attachment 8680837 [details] [diff] [review]
1219806.patch

I don't know if we're still using the probes added in bug 1124428, but I think this should fix the failures.
Flags: needinfo?(kcambridge)
Attachment #8680837 - Flags: review?(vladan.bugzilla)
Landed in https://hg.mozilla.org/mozilla-central/rev/1fbc958f7557 without the review to get things reopened.

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Looks like it worked.
Flags: needinfo?(markh)
Blocks: 1219965
Comment on attachment 8680837 [details] [diff] [review]
1219806.patch

Review of attachment 8680837 [details] [diff] [review]:
-----------------------------------------------------------------

didn't I r+ this patch in its pastebin form over IRC? :)
Attachment #8680837 - Flags: review?(vladan.bugzilla) → review+

Comment 9

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/1fbc958f7557
status-b2g-v2.5: --- → fixed
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: --- → ---
You need to log in before you can comment on or make changes to this bug.