1219806 - xpcshell bustage from version number bump

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Phil Ringnalda (:philor)]

Something didn't like having the version go from 44 to 45, busting xpcshell, https://treeherder.mozilla.org/logviewer.html#?job_id=2546798&repo=mozilla-central

m-c's closed, "on a CLOSED TREE" por favor.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This is preventing us from merging the version bump around and reopening trunk trees. Any chance you can take a look? Is Sync itself still working? Could we just disable these tests for now to green things up until a fix can land?

Comment 2

[Drew Willcoxon :adw]

I'm not familiar with these tests at all.  It looks like Kit recently added the lines where these tests are now failing.

Comment 3

[Drew Willcoxon :adw]

e.g.

http://hg.mozilla.org/mozilla-central/annotate/ac68828c5e3e/services/sync/tests/unit/test_addons_store.js#l398

http://hg.mozilla.org/mozilla-central/annotate/f4ccde68eaf7/services/fxaccounts/tests/xpcshell/test_accounts.js#l230

Comment 4

[Lina Butler [:lina]]

I'm not sure why the telemetry tests are failing. I'll have a look; if nothing else, I can back out the test changes.

Comment 5

[Lina Butler [:lina]]

Attachment: 1219806.patch

I don't know if we're still using the probes added in bug 1124428, but I think this should fix the failures.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Landed in https://hg.mozilla.org/mozilla-central/rev/1fbc958f7557 without the review to get things reopened.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Looks like it worked.

Comment 8

[Vladan Djeric (:vladan)]

Comment on attachment 8680837 [details] [diff] [review]
1219806.patch

Review of attachment 8680837 [details] [diff] [review]:
-----------------------------------------------------------------

didn't I r+ this patch in its pastebin form over IRC? :)

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/1fbc958f7557

Comment 10

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion