1219819 - No doorhanger on about: pages so you can't edit site settings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This is important in the sync setup page where it asks to save your password.

The "Edit Site Settings" item was removed in bug 1174366.

bug 1099088 is to add a doorhanger for about: pages: "This is a secure firefox page". It would fix this issue.

Comment 1

[:Margaret Leibovic]

Anthony, what do you think we should do here?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

This makes sense. 

Once we land bug 1099088, we should add a "edit site settings" link in that doorhanger.

Comment 3

[:Margaret Leibovic]

Not sure why this needs to track 44.

Comment 4

[:Margaret Leibovic]

I see now this tracks 44 because that's where we landed bug 1174366, and it's also where we're shipping web-based about:accounts.

We could back out 1174366 as a temporary fix, but it's unlikely that we'll get approval to land more changes on 44, so we may need to live with this.

But for the longer term we should fix bug 1099088.

Comment 5

[:Margaret Leibovic]

It's too late to do anything about this for 44.

ahunt, can you look into backing out bug 1174366 to fix this for 45? We can just request approval on a backout patch.

Comment 6

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

Review commit: https://reviewboard.mozilla.org/r/31467/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31467/

Comment 7

[Andrzej Hunt :ahunt]

Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

I've just realised I created that patch on top of beta (44) instead of aurora (45) - I should have a new version ready soon (hopefully).

Comment 8

[Andrzej Hunt :ahunt]

Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31467/diff/1-2/

Comment 9

[:Margaret Leibovic]

Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

https://reviewboard.mozilla.org/r/31467/#review28383

Comment 10

[Andrzej Hunt :ahunt]

Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

Approval Request Comment
[Feature/regressing bug #]: Bug 1174366 removed this menu item, Bug 1099088 fixes this bug in trunk, but not on aurora and beta.
[User impact if declined]: Users cannot manage site settings (i.e. logins) for about: pages, including for firefox sync.
[Describe test coverage new/current, TreeHerder]: manual testing.
[Risks and why]: medium risk - we are reenabling a menu item that hasn't been enabled in the current aurora and beta, however this code is currently already in use in release.
[String/UUID change made/needed]: None.

Comment 11

[Andrzej Hunt :ahunt]

Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

We want this patch only on 45 - 45 has made it to Beta, so I'm requesting approval-mozilla-beta instead of approval-mozilla-aurora now.

Approval Request Comment
[Feature/regressing bug #]: Bug 1174366 removed this menu item, Bug 1099088 fixes this bug in trunk, but not on aurora and beta.
[User impact if declined]: Users cannot manage site settings (i.e. logins) for about: pages, including for firefox sync.
[Describe test coverage new/current, TreeHerder]: manual testing.
[Risks and why]: medium risk - we are reenabling a menu item that hasn't been enabled in the current aurora and beta, however this code is currently already in use in release.
[String/UUID change made/needed]: None.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

OK, let's take it

Should be in 45 beta 2.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6b1fd28ad470