Closed Bug 1219819 Opened 4 years ago Closed 4 years ago

No doorhanger on about: pages so you can't edit site settings

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox44 --- wontfix
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed
fennec 45+ ---

People

(Reporter: mcomella, Assigned: ahunt)

References

Details

Attachments

(1 file)

This is important in the sync setup page where it asks to save your password.

The "Edit Site Settings" item was removed in bug 1174366.

bug 1099088 is to add a doorhanger for about: pages: "This is a secure firefox page". It would fix this issue.
Anthony, what do you think we should do here?
Assignee: nobody → liuche
tracking-fennec: ? → 44+
Flags: needinfo?(alam)
This makes sense. 

Once we land bug 1099088, we should add a "edit site settings" link in that doorhanger.
Flags: needinfo?(alam)
Not sure why this needs to track 44.
tracking-fennec: 44+ → ?
I see now this tracks 44 because that's where we landed bug 1174366, and it's also where we're shipping web-based about:accounts.

We could back out 1174366 as a temporary fix, but it's unlikely that we'll get approval to land more changes on 44, so we may need to live with this.

But for the longer term we should fix bug 1099088.
Assignee: liuche → margaret.leibovic
tracking-fennec: ? → 44+
Depends on: 1099088
It's too late to do anything about this for 44.

ahunt, can you look into backing out bug 1174366 to fix this for 45? We can just request approval on a backout patch.
Assignee: margaret.leibovic → ahunt
tracking-fennec: 44+ → 45+
Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

I've just realised I created that patch on top of beta (44) instead of aurora (45) - I should have a new version ready soon (hopefully).
Attachment #8709544 - Flags: review?(margaret.leibovic)
Attachment #8709544 - Flags: review?(margaret.leibovic)
Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31467/diff/1-2/
Attachment #8709544 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

https://reviewboard.mozilla.org/r/31467/#review28383
Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

Approval Request Comment
[Feature/regressing bug #]: Bug 1174366 removed this menu item, Bug 1099088 fixes this bug in trunk, but not on aurora and beta.
[User impact if declined]: Users cannot manage site settings (i.e. logins) for about: pages, including for firefox sync.
[Describe test coverage new/current, TreeHerder]: manual testing.
[Risks and why]: medium risk - we are reenabling a menu item that hasn't been enabled in the current aurora and beta, however this code is currently already in use in release.
[String/UUID change made/needed]: None.
Attachment #8709544 - Flags: approval-mozilla-aurora?
Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

We want this patch only on 45 - 45 has made it to Beta, so I'm requesting approval-mozilla-beta instead of approval-mozilla-aurora now.

Approval Request Comment
[Feature/regressing bug #]: Bug 1174366 removed this menu item, Bug 1099088 fixes this bug in trunk, but not on aurora and beta.
[User impact if declined]: Users cannot manage site settings (i.e. logins) for about: pages, including for firefox sync.
[Describe test coverage new/current, TreeHerder]: manual testing.
[Risks and why]: medium risk - we are reenabling a menu item that hasn't been enabled in the current aurora and beta, however this code is currently already in use in release.
[String/UUID change made/needed]: None.
Attachment #8709544 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment on attachment 8709544 [details]
MozReview Request: Bug 1219819 - backout removal of "Edit Site Settings" menu item r=margaret

OK, let's take it

Should be in 45 beta 2.
Attachment #8709544 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/6b1fd28ad470
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.