1219820 - When pressing 'left' with an element in the memory tree selected, all rows become unselected

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Brian Grinstead [:bgrins]]

STR:
Take snapshot
Select an element in the tree
Press left

Expected:
No change

Actual:
All rows become unselected and you can't keyboard navigate anymore

Comment 1

[Brian Grinstead [:bgrins]]

Looks like 
  _focusParentNode() {
    const parent = this.props.getParent(this.state.focused);
    if (parent) {
      // Not null, even for a top-level tree item
      // parent == Object { name: null, bytes: 0, totalBytes: 497688, count: 0, totalCount: 8712, children: Array[4], id: 1, parent: undefined }
      this.setState({
        focused: parent
      });
    }
  }

I guess that there is a root parent that isn't being rendered by the tree.  Not sure if we want to add a property to each item to indicated whether it should be rendered, special case `if (!parent || !parent.parent)`, or something else.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Do not try and select the hidden root when navigating the heap view tree with keyboard shortcuts

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b7e22cd2ec02

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7e22cd2ec02

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=cb029edb917f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b7e22cd2ec02

Comment 7

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8a18306d24a8