When pressing 'left' with an element in the memory tree selected, all rows become unselected

RESOLVED FIXED in Firefox 45, Firefox OS v2.5

Status

RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: bgrins, Assigned: fitzgen)

Tracking

Trunk
Firefox 45

Firefox Tracking Flags

(firefox45 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
STR:
Take snapshot
Select an element in the tree
Press left

Expected:
No change

Actual:
All rows become unselected and you can't keyboard navigate anymore
(Reporter)

Comment 1

3 years ago
Looks like 
  _focusParentNode() {
    const parent = this.props.getParent(this.state.focused);
    if (parent) {
      // Not null, even for a top-level tree item
      // parent == Object { name: null, bytes: 0, totalBytes: 497688, count: 0, totalCount: 8712, children: Array[4], id: 1, parent: undefined }
      this.setState({
        focused: parent
      });
    }
  }

I guess that there is a root parent that isn't being rendered by the tree.  Not sure if we want to add a property to each item to indicated whether it should be rendered, special case `if (!parent || !parent.parent)`, or something else.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Has STR: --- → yes
Created attachment 8680940 [details] [diff] [review]
Do not try and select the hidden root when navigating the heap view tree with keyboard shortcuts
Attachment #8680940 - Flags: review?(jsantell)
Attachment #8680940 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/b7e22cd2ec02
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45

Comment 6

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b7e22cd2ec02
status-b2g-v2.5: --- → fixed
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: --- → ---

Comment 8

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8a18306d24a8
status-b2g-v2.5: --- → fixed

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.