Closed Bug 1219820 Opened 4 years ago Closed 4 years ago

When pressing 'left' with an element in the memory tree selected, all rows become unselected

Categories

(DevTools :: Memory, defect)

defect
Not set

Tracking

(firefox45 fixed, b2g-v2.5 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: bgrins, Assigned: fitzgen)

Details

Attachments

(1 file)

STR:
Take snapshot
Select an element in the tree
Press left

Expected:
No change

Actual:
All rows become unselected and you can't keyboard navigate anymore
Looks like 
  _focusParentNode() {
    const parent = this.props.getParent(this.state.focused);
    if (parent) {
      // Not null, even for a top-level tree item
      // parent == Object { name: null, bytes: 0, totalBytes: 497688, count: 0, totalCount: 8712, children: Array[4], id: 1, parent: undefined }
      this.setState({
        focused: parent
      });
    }
  }

I guess that there is a root parent that isn't being rendered by the tree.  Not sure if we want to add a property to each item to indicated whether it should be rendered, special case `if (!parent || !parent.parent)`, or something else.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Has STR: --- → yes
Attachment #8680940 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/b7e22cd2ec02
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.