Closed Bug 1219821 Opened 4 years ago Closed 4 years ago

Reintroduce runtime failure for use of shared memory in asm.js in non-shmem-enabled build

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file)

Bug 1193777 changed a dynamic failure to an assertion, but this assertion does not hold because previous dynamic guards that would appear to make the assertion valid are only treated as warnings and do not abort the compilation.

This causes failures on runs where shared memory is not enabled (discovered after branching for aurora).
Includes a drive-by fix for the missing guard in gating.js.
Attachment #8680720 - Flags: review?(arai.unmht)
Comment on attachment 8680720 [details] [diff] [review]
bug1219821-assert.patch

Review of attachment 8680720 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for fixing this!
the currentToken is next |function| for testcase.
it could be EOF, but at least the pos.begin value is not invalid.
Attachment #8680720 - Flags: review?(arai.unmht) → review+
https://hg.mozilla.org/mozilla-central/rev/83c882b4cdc8
https://hg.mozilla.org/releases/mozilla-aurora/rev/dd621727d202
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
You need to log in before you can comment on or make changes to this bug.