1219821 - Reintroduce runtime failure for use of shared memory in asm.js in non-shmem-enabled build

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Lars T Hansen [:lth]]

Bug 1193777 changed a dynamic failure to an assertion, but this assertion does not hold because previous dynamic guards that would appear to make the assertion valid are only treated as warnings and do not abort the compilation.

This causes failures on runs where shared memory is not enabled (discovered after branching for aurora).

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1219821-assert.patch

Includes a drive-by fix for the missing guard in gating.js.

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8680720 [details] [diff] [review]
bug1219821-assert.patch

Review of attachment 8680720 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for fixing this!
the currentToken is next |function| for testcase.
it could be EOF, but at least the pos.begin value is not invalid.

Comment 3

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/83c882b4cdc8

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/83c882b4cdc8
https://hg.mozilla.org/releases/mozilla-aurora/rev/dd621727d202

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/83c882b4cdc8

Comment 6

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 7

[Ryan VanderMeulen [:RyanVM]]

And re-landed on b2g44 (long story, don't ask).
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/dd621727d202