Closed Bug 1219835 Opened 10 years ago Closed 10 years ago

Do not disturb notification option is not working on Mac OS 10.8

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect)

44 Branch
x86_64
macOS
defect
Not set
normal

Tracking

(firefox43 unaffected, firefox44 affected, firefox45 affected)

RESOLVED DUPLICATE of bug 1220337
Tracking Status
firefox43 --- unaffected
firefox44 --- affected
firefox45 --- affected

People

(Reporter: poiegas, Unassigned)

References

Details

Attachments

(1 file)

Reproducible with: 44.0a1 (2015-10-29) Affected platform: Mac OS 10.8 Steps to reproduce: 1. Navigate to "https://pdehaan.github.io/push-notification-test/" page. 2. Click on "pop Notification" button and select "Always Receive Notifications" from doorhanger. 3. Hover the displayed notification and click the "Settings" button (cog wheel). 4. Select "Do not disturb me until I restart Nightly" option. 5. Click again on "pop Notifications" button and observe the behavior. Expected results: No notification is displayed for the website until the browser is restarted. Actual results: A new notification is displayed. Notes: - This issue does not reproduces on Mac OS 10.6 and 10.7. - The do not disturb option is not available in Mac OS 10.9, 10.10 and 10.11. - Tested also on a second link provided for Push Notifications testing (https://people.mozilla.org/~ewong2/push-notification-test/) and it behaves the same on Mac OS 10.8. - Tested on Windows XP to 10 and the option correctly works.
Thanks for the report! Paul, in the future can you please Clear the Browser Console before reproducing and then include any relevant output that appears? There was probably an error in alert.js. Kit, is this something you can debug on your 10.8 machine? I suspect we're calling into the OS X Notification Center code but then returning with a failure to fallback to XUL since we should be using native notifications on 10.8 AFAIK.
Component: DOM: Push Notifications → Notifications and Alerts
Flags: needinfo?(kcambridge)
Product: Core → Toolkit
Sure thing, I'll take a look once I get home.
Thanks! The last line > NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAlertsDoNotDisturb.manualDoNotDisturb] alert.js:249:0 is useful for troubleshooting this.
"Do not disturb me until I restart Nightly" menu option is also ignored on Ubuntu Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0 Build ID: 20151106030423
Reproducible with FireFox Nightly 45.0a1 (2015-11-06) on Mac 10.9 and 10.10.
As of bug 1220337, we should be using native notifications on 10.8. "Do not disturb" shouldn't be shown in content preferences, since we rely on the system's do not disturb switch. Unfortunately, 10.8 doesn't support the action menu. The user can only click on the notification to fire the `click` event, or drag to dismiss it. If the "Alerts" style is set in System Prefs > Notifications, we'll only show the "Close" button; otherwise, if "Banners" (the default) is set, we won't show any buttons.
Flags: needinfo?(kcambridge)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment