Closed
Bug 1219836
Opened 9 years ago
Closed 9 years ago
Factor out app-global elements to a separate file
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S11 (13Nov)
People
(Reporter: cwiiis, Assigned: cwiiis)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
We were doing so well until edit-mode came along and spoiled things :) There are now some app-global elements that are mostly controlled by app.js, but still used in pages.js. We should have a window.js further up in the hierarchy that can handle window-level logic that isn't specific to a panel.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Attachment #8680740 -
Flags: review?(gmarty)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8680740 [details] [review] [gaia] Cwiiis:bug1219836-homescreen-window-refactor > mozilla-b2g:master I love this refactoring. Makes it so much cleaner. r+!
Attachment #8680740 -
Flags: review?(gmarty) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Whiteboard: [systemsfe]
|
||
Comment 3•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/00c4842e1bd23b966eefffa3f856f1ccb00c39c3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•